forked from sysown/proxysql
-
Notifications
You must be signed in to change notification settings - Fork 0
Use proxy_sqlite3_* wrappers and canonical proxy symbol TU #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8dc4246
Introduce canonical proxy_sqlite3 symbol TU; update lib Makefile; rem…
renecannao a24b8ad
Use proxy_sqlite3_* for SQLite calls in Anomaly_Detector.cpp (address…
renecannao 2dfd61a
Replace remaining direct sqlite3_* calls with proxy_sqlite3_* equival…
renecannao 7bf9121
sqlite3: fix duplicate proxy declarations and add forward declarations
renecannao 0db022a
Apply fixes
renecannao 4f0e6e0
Disable sqlite3 plugin function replacement; warn instead
renecannao f877366
Restore commented SQLite3DB::LoadPlugin reference with TODO
renecannao 6ce0538
Keep main.cpp only; remove accidental backup from commits
renecannao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
rg -n '\bMAIN_PROXY_SQLITE3\b'Repository: ProxySQL/proxysql-vec
Length of output: 186
🏁 Script executed:
head -150 include/sqlite3db.h | cat -nRepository: ProxySQL/proxysql-vec
Length of output: 7784
🏁 Script executed:
rg -n 'define\s+MAIN_PROXY_SQLITE3' -t c -t cpp -t hRepository: ProxySQL/proxysql-vec
Length of output: 254
🏁 Script executed:
Repository: ProxySQL/proxysql-vec
Length of output: 186
🏁 Script executed:
Repository: ProxySQL/proxysql-vec
Length of output: 47
🏁 Script executed:
sed -n '82,139p' include/sqlite3db.hRepository: ProxySQL/proxysql-vec
Length of output: 2902
Add
proxy_sqlite3_enable_load_extensiondefinition to the MAIN_PROXY_SQLITE3 block.The extern declaration exists at line 43, but the MAIN_PROXY_SQLITE3 definition block (lines 82–139) is missing the corresponding definition. Since MAIN_PROXY_SQLITE3 is actively defined in test files (
test/tap/tests/setparser_test.cpp,test/tap/tests/sqlite3-t.cpp,test/tap/tests/setparser_test_common.h), this asymmetry will cause missing symbol definitions in those compilation units.Fix
sqlite3* (*proxy_sqlite3_db_handle)(sqlite3_stmt*); +int (*proxy_sqlite3_enable_load_extension)(sqlite3*, int); int (*proxy_sqlite3_auto_extension)(void(*)(void));🤖 Prompt for AI Agents