Skip to content

add rpm-macros#17

Merged
mirostauder merged 1 commit intomainfrom
v3.0-systemd_rpm_macros
Feb 5, 2026
Merged

add rpm-macros#17
mirostauder merged 1 commit intomainfrom
v3.0-systemd_rpm_macros

Conversation

@mirostauder
Copy link
Copy Markdown
Contributor

@mirostauder mirostauder commented Feb 5, 2026

update build images with new package systemd-rpm-macros

remove obsolete fedora41 builds

Summary by CodeRabbit

  • Chores
    • Added systemd-rpm-macros package to build dependencies across multiple container images (AlmaLinux 8/9/10, CentOS 9/10, Fedora 41/42/43, and OpenSUSE 15/16) to support systemd macro functionality in build environments.

@mirostauder mirostauder self-assigned this Feb 5, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 5, 2026

📝 Walkthrough

Walkthrough

Adds systemd-rpm-macros package to yum/dnf/zypper installation commands across 19 Dockerfiles spanning multiple distribution variants (AlmaLinux, CentOS, Fedora, OpenSUSE) in both clang and standard build image directories.

Changes

Cohort / File(s) Summary
Clang Build Images
build-clang-images/build-clang-almalinux{8,9,10}/Dockerfile, build-clang-images/build-clang-centos{9,10}/Dockerfile, build-clang-images/build-clang-fedora{42,43}/Dockerfile, build-clang-images/build-clang-opensuse{15,16}/Dockerfile, build-clang-images/obsolete/build-clang-fedora41/Dockerfile
Adds systemd-rpm-macros to package installation list alongside existing libevent-devel dependency in respective yum/dnf/zypper install blocks.
Standard Build Images
build-images/build-almalinux{8,9,10}/Dockerfile, build-images/build-centos{9,10}/Dockerfile, build-images/build-fedora{42,43}/Dockerfile, build-images/build-opensuse{15,16}/Dockerfile, build-images/obsolete/build-fedora41/Dockerfile
Adds systemd-rpm-macros to package installation list alongside existing ncurses-devel dependency in respective yum/dnf/zypper install blocks.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related issues

Poem

🐰 A bushy-tailed fix, so simple and pure,
Macros for systems, a robust cure,
Nineteen dockerfiles, all patched in a row,
Build dependencies dance—watch the images grow!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title "add rpm-macros" is vague and doesn't clearly specify which package or context is being addressed, given that systemd-rpm-macros is added across 17 different Dockerfiles. Consider using a more descriptive title like "Add systemd-rpm-macros to Docker build images" to clearly identify the specific package and scope of changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch v3.0-systemd_rpm_macros

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mirostauder mirostauder merged commit 5b16c45 into main Feb 5, 2026
1 check was pending
@mirostauder mirostauder linked an issue Feb 5, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build Images Need systemd-rpm-macros for Proper RPM Uninstall Support

1 participant