-
Notifications
You must be signed in to change notification settings - Fork 1
fix: resolve CI failures for MariaDB, Percona, ts tests, fan-in #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,8 +23,8 @@ exists $sb_dir | |
| exec $sb_dir/check_ms_nodes | ||
| stdout '# Master 1' | ||
| stdout '# Master 2' | ||
| stdout -count=2 'Slave_IO_Running: Yes' | ||
| stdout -count=2 'Slave_SQL_Running: Yes' | ||
| stdout -count=2 '(Slave|Replica)_IO_Running: Yes' | ||
| stdout -count=2 '(Slave|Replica)_SQL_Running: Yes' | ||
| ! stderr . | ||
|
|
||
| check_sandbox_manifest $sb_dir multi_source | ||
|
|
@@ -33,6 +33,7 @@ env required_ports=3 | |
| [version_is_at_least:$db_version:8.0.0] env required_ports=6 | ||
| check_ports $sb_dir $required_ports | ||
|
|
||
| sleep 3 | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using a fixed A more robust solution would be to poll for the replication status. Since the test-scripting language doesn't seem to support loops, you could create a helper script (e.g., in shell) that waits for replication to be caught up. For example, a #!/bin/bash
SB_DIR=$1
TIMEOUT=30
for i in $(seq 1 $TIMEOUT); do
# This command will return a non-empty string if any channel has a non-zero or NULL lag.
LAGGING_CHANNELS=$($SB_DIR/n3 -e "SHOW SLAVE STATUS\G" | grep 'Seconds_Behind_Master:' | grep -v ': 0$')
if [ -z "$LAGGING_CHANNELS" ]; then
echo "Replication caught up."
exit 0
fi
sleep 1
done
echo "Timeout waiting for replication to catch up."
exit 1Then you could call this script from the test template instead of using |
||
| exec $HOME/sandboxes/fan_in_msb_{{.DbPathVer}}/test_replication | ||
| stdout '# fail: 0' | ||
| ! stderr . | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: ProxySQL/dbdeployer
Length of output: 774
🏁 Script executed:
Repository: ProxySQL/dbdeployer
Length of output: 2063
🏁 Script executed:
Repository: ProxySQL/dbdeployer
Length of output: 2071
🏁 Script executed:
Repository: ProxySQL/dbdeployer
Length of output: 2356
🏁 Script executed:
Repository: ProxySQL/dbdeployer
Length of output: 188
🏁 Script executed:
Repository: ProxySQL/dbdeployer
Length of output: 1848
🏁 Script executed:
Repository: ProxySQL/dbdeployer
Length of output: 831
🏁 Script executed:
Repository: ProxySQL/dbdeployer
Length of output: 1600
🏁 Script executed:
Repository: ProxySQL/dbdeployer
Length of output: 792
🏁 Script executed:
Repository: ProxySQL/dbdeployer
Length of output: 45
🏁 Script executed:
Repository: ProxySQL/dbdeployer
Length of output: 319
Checksums are required and missing—these entries will fail validation.
The five MariaDB entries cannot be used without checksums. The tarball registry validation code explicitly rejects entries with missing checksums for all flavors except
tidb(mariadb entries are not exempted):You must populate the
checksumfield using the format"SHA512:CHECKSUM_VALUE"or"MD5:CHECKSUM_VALUE". Note thatarchive.mariadb.orgdoes not provide standard checksum files (SHA256SUMS, sha256sum.txt both return 404), so you may need to download the tarballs and compute their checksums locally usingsha512sum, or check if MariaDB provides checksums through an alternate method.🤖 Prompt for AI Agents