Skip to content

feat: add MariaDB and Percona Server to tarball registry#78

Merged
renecannao merged 2 commits intomasterfrom
feature/tarball-registry-mariadb-percona
Apr 5, 2026
Merged

feat: add MariaDB and Percona Server to tarball registry#78
renecannao merged 2 commits intomasterfrom
feature/tarball-registry-mariadb-percona

Conversation

@renecannao
Copy link
Copy Markdown

@renecannao renecannao commented Apr 5, 2026

Summary

Adds MariaDB and Percona Server tarballs to the download registry so dbdeployer downloads list --flavor=mariadb and --flavor=percona work.

MariaDB (8 entries)

  • 10.6.21 (LTS) — Linux amd64 + arm64
  • 10.11.11 (LTS) — Linux amd64 + arm64
  • 11.4.5 (LTS) — Linux amd64 + arm64
  • 11.7.2 (short-term) — Linux amd64
  • 11.8.1 (short-term) — Linux amd64

Percona Server (7 new entries, 9 existing)

  • 5.7.44-48 — Linux amd64 (new)
  • 8.0.36-28 — Linux amd64 (new)
  • 8.0.40-31 — Linux amd64 glibc2.35 (new)
  • 8.4.0-1 — Linux amd64 (new)
  • 8.4.2-2 — Linux amd64 (new)
  • 8.4.3-3 — Linux amd64 glibc2.35 (new)

Test Plan

  • Build succeeds
  • dbdeployer downloads list --flavor=mariadb shows 8 entries
  • dbdeployer downloads list --flavor=percona shows all entries
  • No duplicate entries (uniqueness check passes)

Summary by CodeRabbit

  • Chores

    • Added multiple Percona Server Linux x86_64 "minimal" tarball downloads for 5.7.41–5.7.44, 8.0.33–8.0.36, 8.0.39–8.0.40, and 8.4.0–8.4.4.
    • Added MariaDB Linux tarball downloads (non-minimal) for 10.6.25, 10.11.25, and 11.0.10–11.8.10; amd64 for all listed versions and arm64 for 10.6.25, 10.11.25, and 11.4.10.
  • Tests

    • Added CI jobs to run Percona and MariaDB sandbox deployments and automated replication checks.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 5, 2026

📝 Walkthrough

Walkthrough

Added multiple MariaDB and Percona Server tarball metadata entries to the downloads registry (downloads/tarball_list.json) and added two new GitHub Actions integration test jobs (.github/workflows/integration_tests.yml) that build dbdeployer, unpack tarballs, deploy single and replication sandboxes, verify replication, and perform cleanup.

Changes

Cohort / File(s) Summary
Tarball registry
downloads/tarball_list.json
Appended new Linux tarball metadata: 14 MariaDB entries (flavor: mariadb, minimal: false) for versions 10.6.25, 10.11.25, and 11.0.10–11.8.10 (amd64 and selected arm64); 14 Percona Server “minimal” amd64 entries (flavor: percona, minimal: true) covering 5.7.x, 8.0.x, and 8.4.x releases. All items include name, OS, arch, url, short_version, version, notes: "added with version 2.1.1", date_added: "2026-04-05 00:00", size: 0, and omit checksum.
CI workflow
.github/workflows/integration_tests.yml
Added percona-test and mariadb-test jobs that use Go 1.22 to build dbdeployer, download and unpack tarballs into SANDBOX_BINARY, run dbdeployer deployments for single and replication, perform replication verification (MariaDB writes/checks a marker; Percona runs replication checks), and run cleanup (dbdeployer delete all --skip-confirm + pkill mysqld).

Sequence Diagram(s)

sequenceDiagram
  participant GH as "GitHub Actions (runner)"
  participant Repo as "Repository"
  participant Build as "dbdeployer build (Go 1.22)"
  participant Fetch as "Tarball download/unpack"
  participant Deployer as "dbdeployer"
  participant Sandbox as "Sandboxed mysqld instances"
  participant Verifier as "Replication verification"
  participant Cleanup as "Cleanup (delete/pkill)"

  GH->>Repo: checkout
  GH->>Build: go build ./cmd/dbdeployer
  GH->>Fetch: download selected tarball(s)
  Fetch->>Deployer: place binaries into SANDBOX_BINARY
  GH->>Deployer: run deploy single
  Deployer->>Sandbox: start single instance
  GH->>Deployer: run deploy replication
  Deployer->>Sandbox: start master & replicas
  Sandbox->>Verifier: expose endpoints/scripts
  Verifier->>Sandbox: perform replication checks (write/read marker)
  Verifier-->>GH: pass/fail
  GH->>Cleanup: dbdeployer delete all + pkill mysqld
  Cleanup-->>GH: finished
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Poem

🐇 I hopped across the download trail,
New tarballs snug within my tail,
Percona, Maria with sandbox cheer,
Tests that build and replication clear—
A rabbit's clap, the deploys prevail! 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: adding MariaDB and Percona Server entries to the tarball registry, matching the primary modification in downloads/tarball_list.json and the CI workflow enhancements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/tarball-registry-mariadb-percona

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@downloads/tarball_list.json`:
- Around line 3125-3304: Entries for Percona and MariaDB tarballs (e.g., name
fields like "Percona-Server-5.7.44-48-Linux.x86_64.glibc2.17-minimal.tar.gz",
"Percona-Server-8.0.36-28-Linux.x86_64...",
"mariadb-10.6.21-linux-x86_64.tar.gz", etc.) are missing the required checksum
causing TarballFileInfoValidation failures; add a checksum property to each new
non-tidb entry by computing the tarball's SHA256 (or the project's canonical
algorithm) and inserting a "checksum" field with that value into each JSON
object so validation succeeds. Ensure every new percona and mariadb object in
this diff includes the checksum key with the correct digest.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2528448d-fa01-4046-a5b9-d0a44d897358

📥 Commits

Reviewing files that changed from the base of the PR and between f9ae64f and 1b574a5.

📒 Files selected for processing (1)
  • downloads/tarball_list.json

Comment on lines +3125 to +3304
"name": "Percona-Server-5.7.44-48-Linux.x86_64.glibc2.17-minimal.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.percona.com/downloads/Percona-Server-5.7/Percona-Server-5.7.44-48/binary/tarball/Percona-Server-5.7.44-48-Linux.x86_64.glibc2.17-minimal.tar.gz",
"flavor": "percona",
"minimal": true,
"size": 0,
"short_version": "5.7",
"version": "5.7.44",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "Percona-Server-8.0.36-28-Linux.x86_64.glibc2.17-minimal.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.percona.com/downloads/Percona-Server-8.0/Percona-Server-8.0.36-28/binary/tarball/Percona-Server-8.0.36-28-Linux.x86_64.glibc2.17-minimal.tar.gz",
"flavor": "percona",
"minimal": true,
"size": 0,
"short_version": "8.0",
"version": "8.0.36",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "Percona-Server-8.0.40-31-Linux.x86_64.glibc2.35-minimal.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.percona.com/downloads/Percona-Server-8.0/Percona-Server-8.0.40-31/binary/tarball/Percona-Server-8.0.40-31-Linux.x86_64.glibc2.35-minimal.tar.gz",
"flavor": "percona",
"minimal": true,
"size": 0,
"short_version": "8.0",
"version": "8.0.40",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "Percona-Server-8.4.0-1-Linux.x86_64.glibc2.17-minimal.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.percona.com/downloads/Percona-Server-8.4/Percona-Server-8.4.0-1/binary/tarball/Percona-Server-8.4.0-1-Linux.x86_64.glibc2.17-minimal.tar.gz",
"flavor": "percona",
"minimal": true,
"size": 0,
"short_version": "8.4",
"version": "8.4.0",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "Percona-Server-8.4.2-2-Linux.x86_64.glibc2.17-minimal.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.percona.com/downloads/Percona-Server-8.4/Percona-Server-8.4.2-2/binary/tarball/Percona-Server-8.4.2-2-Linux.x86_64.glibc2.17-minimal.tar.gz",
"flavor": "percona",
"minimal": true,
"size": 0,
"short_version": "8.4",
"version": "8.4.2",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "Percona-Server-8.4.3-3-Linux.x86_64.glibc2.35-minimal.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.percona.com/downloads/Percona-Server-8.4/Percona-Server-8.4.3-3/binary/tarball/Percona-Server-8.4.3-3-Linux.x86_64.glibc2.35-minimal.tar.gz",
"flavor": "percona",
"minimal": true,
"size": 0,
"short_version": "8.4",
"version": "8.4.3",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "mariadb-10.6.21-linux-x86_64.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.mariadb.com/MariaDB/mariadb-10.6.21/bintar-linux-x86_64/mariadb-10.6.21-linux-x86_64.tar.gz",
"flavor": "mariadb",
"minimal": false,
"size": 0,
"short_version": "10.6",
"version": "10.6.21",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "mariadb-10.6.21-linux-aarch64.tar.gz",
"OS": "Linux",
"arch": "arm64",
"url": "https://downloads.mariadb.com/MariaDB/mariadb-10.6.21/bintar-linux-aarch64/mariadb-10.6.21-linux-aarch64.tar.gz",
"flavor": "mariadb",
"minimal": false,
"size": 0,
"short_version": "10.6",
"version": "10.6.21",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "mariadb-10.11.11-linux-x86_64.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.mariadb.com/MariaDB/mariadb-10.11.11/bintar-linux-x86_64/mariadb-10.11.11-linux-x86_64.tar.gz",
"flavor": "mariadb",
"minimal": false,
"size": 0,
"short_version": "10.11",
"version": "10.11.11",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "mariadb-10.11.11-linux-aarch64.tar.gz",
"OS": "Linux",
"arch": "arm64",
"url": "https://downloads.mariadb.com/MariaDB/mariadb-10.11.11/bintar-linux-aarch64/mariadb-10.11.11-linux-aarch64.tar.gz",
"flavor": "mariadb",
"minimal": false,
"size": 0,
"short_version": "10.11",
"version": "10.11.11",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "mariadb-11.4.5-linux-x86_64.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.mariadb.com/MariaDB/mariadb-11.4.5/bintar-linux-x86_64/mariadb-11.4.5-linux-x86_64.tar.gz",
"flavor": "mariadb",
"minimal": false,
"size": 0,
"short_version": "11.4",
"version": "11.4.5",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "mariadb-11.4.5-linux-aarch64.tar.gz",
"OS": "Linux",
"arch": "arm64",
"url": "https://downloads.mariadb.com/MariaDB/mariadb-11.4.5/bintar-linux-aarch64/mariadb-11.4.5-linux-aarch64.tar.gz",
"flavor": "mariadb",
"minimal": false,
"size": 0,
"short_version": "11.4",
"version": "11.4.5",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "mariadb-11.7.2-linux-x86_64.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.mariadb.com/MariaDB/mariadb-11.7.2/bintar-linux-x86_64/mariadb-11.7.2-linux-x86_64.tar.gz",
"flavor": "mariadb",
"minimal": false,
"size": 0,
"short_version": "11.7",
"version": "11.7.2",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "mariadb-11.8.1-linux-x86_64.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.mariadb.com/MariaDB/mariadb-11.8.1/bintar-linux-x86_64/mariadb-11.8.1-linux-x86_64.tar.gz",
"flavor": "mariadb",
"minimal": false,
"size": 0,
"short_version": "11.8",
"version": "11.8.1",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Add checksum for all newly added Percona/MariaDB tarballs.

For non-tidb entries, missing checksums are treated as validation errors (TarballFileInfoValidation). On Line 3125 through Line 3304, every new percona and mariadb tarball omits checksum, so these entries are not integrity-verifiable and can fail validation flows.

Proposed patch pattern (apply to each new entry)
   {
     "name": "Percona-Server-5.7.44-48-Linux.x86_64.glibc2.17-minimal.tar.gz",
+    "checksum": "SHA512:<vendor-published-checksum>",
     "OS": "Linux",
     "arch": "amd64",
     "url": "https://downloads.percona.com/downloads/Percona-Server-5.7/Percona-Server-5.7.44-48/binary/tarball/Percona-Server-5.7.44-48-Linux.x86_64.glibc2.17-minimal.tar.gz",
     "flavor": "percona",
     "minimal": true,
     "size": 0,
     "short_version": "5.7",
     "version": "5.7.44",
     "notes": "added with version 2.1.1",
     "date_added": "2026-04-05 00:00"
   }
   {
     "name": "mariadb-10.6.21-linux-x86_64.tar.gz",
+    "checksum": "SHA512:<vendor-published-checksum>",
     "OS": "Linux",
     "arch": "amd64",
     "url": "https://downloads.mariadb.com/MariaDB/mariadb-10.6.21/bintar-linux-x86_64/mariadb-10.6.21-linux-x86_64.tar.gz",
     "flavor": "mariadb",
     "minimal": false,
     "size": 0,
     "short_version": "10.6",
     "version": "10.6.21",
     "notes": "added with version 2.1.1",
     "date_added": "2026-04-05 00:00"
   }
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@downloads/tarball_list.json` around lines 3125 - 3304, Entries for Percona
and MariaDB tarballs (e.g., name fields like
"Percona-Server-5.7.44-48-Linux.x86_64.glibc2.17-minimal.tar.gz",
"Percona-Server-8.0.36-28-Linux.x86_64...",
"mariadb-10.6.21-linux-x86_64.tar.gz", etc.) are missing the required checksum
causing TarballFileInfoValidation failures; add a checksum property to each new
non-tidb entry by computing the tarball's SHA256 (or the project's canonical
algorithm) and inserting a "checksum" field with that value into each JSON
object so validation succeeds. Ensure every new percona and mariadb object in
this diff includes the checksum key with the correct digest.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates downloads/tarball_list.json with several new entries for Percona Server and MariaDB. The reviewer noted that these new entries lack checksums and have file sizes set to zero, which hinders the tool's ability to verify downloads and report progress accurately.

Comment on lines +3125 to +3201
"name": "Percona-Server-5.7.44-48-Linux.x86_64.glibc2.17-minimal.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.percona.com/downloads/Percona-Server-5.7/Percona-Server-5.7.44-48/binary/tarball/Percona-Server-5.7.44-48-Linux.x86_64.glibc2.17-minimal.tar.gz",
"flavor": "percona",
"minimal": true,
"size": 0,
"short_version": "5.7",
"version": "5.7.44",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "Percona-Server-8.0.36-28-Linux.x86_64.glibc2.17-minimal.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.percona.com/downloads/Percona-Server-8.0/Percona-Server-8.0.36-28/binary/tarball/Percona-Server-8.0.36-28-Linux.x86_64.glibc2.17-minimal.tar.gz",
"flavor": "percona",
"minimal": true,
"size": 0,
"short_version": "8.0",
"version": "8.0.36",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "Percona-Server-8.0.40-31-Linux.x86_64.glibc2.35-minimal.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.percona.com/downloads/Percona-Server-8.0/Percona-Server-8.0.40-31/binary/tarball/Percona-Server-8.0.40-31-Linux.x86_64.glibc2.35-minimal.tar.gz",
"flavor": "percona",
"minimal": true,
"size": 0,
"short_version": "8.0",
"version": "8.0.40",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "Percona-Server-8.4.0-1-Linux.x86_64.glibc2.17-minimal.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.percona.com/downloads/Percona-Server-8.4/Percona-Server-8.4.0-1/binary/tarball/Percona-Server-8.4.0-1-Linux.x86_64.glibc2.17-minimal.tar.gz",
"flavor": "percona",
"minimal": true,
"size": 0,
"short_version": "8.4",
"version": "8.4.0",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "Percona-Server-8.4.2-2-Linux.x86_64.glibc2.17-minimal.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.percona.com/downloads/Percona-Server-8.4/Percona-Server-8.4.2-2/binary/tarball/Percona-Server-8.4.2-2-Linux.x86_64.glibc2.17-minimal.tar.gz",
"flavor": "percona",
"minimal": true,
"size": 0,
"short_version": "8.4",
"version": "8.4.2",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "Percona-Server-8.4.3-3-Linux.x86_64.glibc2.35-minimal.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.percona.com/downloads/Percona-Server-8.4/Percona-Server-8.4.3-3/binary/tarball/Percona-Server-8.4.3-3-Linux.x86_64.glibc2.35-minimal.tar.gz",
"flavor": "percona",
"minimal": true,
"size": 0,
"short_version": "8.4",
"version": "8.4.3",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new Percona Server entries are missing checksums and have a size of 0. While this follows the pattern of some recent placeholders in this file, it prevents dbdeployer from verifying the integrity of the downloads and showing accurate progress. If these binaries are currently available, it is highly recommended to include their SHA512 or MD5 checksums and actual file sizes.

Comment on lines 3203 to 3305
"name": "mariadb-10.6.21-linux-x86_64.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.mariadb.com/MariaDB/mariadb-10.6.21/bintar-linux-x86_64/mariadb-10.6.21-linux-x86_64.tar.gz",
"flavor": "mariadb",
"minimal": false,
"size": 0,
"short_version": "10.6",
"version": "10.6.21",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "mariadb-10.6.21-linux-aarch64.tar.gz",
"OS": "Linux",
"arch": "arm64",
"url": "https://downloads.mariadb.com/MariaDB/mariadb-10.6.21/bintar-linux-aarch64/mariadb-10.6.21-linux-aarch64.tar.gz",
"flavor": "mariadb",
"minimal": false,
"size": 0,
"short_version": "10.6",
"version": "10.6.21",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "mariadb-10.11.11-linux-x86_64.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.mariadb.com/MariaDB/mariadb-10.11.11/bintar-linux-x86_64/mariadb-10.11.11-linux-x86_64.tar.gz",
"flavor": "mariadb",
"minimal": false,
"size": 0,
"short_version": "10.11",
"version": "10.11.11",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "mariadb-10.11.11-linux-aarch64.tar.gz",
"OS": "Linux",
"arch": "arm64",
"url": "https://downloads.mariadb.com/MariaDB/mariadb-10.11.11/bintar-linux-aarch64/mariadb-10.11.11-linux-aarch64.tar.gz",
"flavor": "mariadb",
"minimal": false,
"size": 0,
"short_version": "10.11",
"version": "10.11.11",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "mariadb-11.4.5-linux-x86_64.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.mariadb.com/MariaDB/mariadb-11.4.5/bintar-linux-x86_64/mariadb-11.4.5-linux-x86_64.tar.gz",
"flavor": "mariadb",
"minimal": false,
"size": 0,
"short_version": "11.4",
"version": "11.4.5",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "mariadb-11.4.5-linux-aarch64.tar.gz",
"OS": "Linux",
"arch": "arm64",
"url": "https://downloads.mariadb.com/MariaDB/mariadb-11.4.5/bintar-linux-aarch64/mariadb-11.4.5-linux-aarch64.tar.gz",
"flavor": "mariadb",
"minimal": false,
"size": 0,
"short_version": "11.4",
"version": "11.4.5",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "mariadb-11.7.2-linux-x86_64.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.mariadb.com/MariaDB/mariadb-11.7.2/bintar-linux-x86_64/mariadb-11.7.2-linux-x86_64.tar.gz",
"flavor": "mariadb",
"minimal": false,
"size": 0,
"short_version": "11.7",
"version": "11.7.2",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
},
{
"name": "mariadb-11.8.1-linux-x86_64.tar.gz",
"OS": "Linux",
"arch": "amd64",
"url": "https://downloads.mariadb.com/MariaDB/mariadb-11.8.1/bintar-linux-x86_64/mariadb-11.8.1-linux-x86_64.tar.gz",
"flavor": "mariadb",
"minimal": false,
"size": 0,
"short_version": "11.8",
"version": "11.8.1",
"notes": "added with version 2.1.1",
"date_added": "2026-04-05 00:00"
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new MariaDB entries are missing checksums and have a size of 0. Without checksums, the tool cannot verify the downloaded files. Please consider adding the checksums and the actual file sizes for these entries to ensure a better user experience and security.

@renecannao renecannao force-pushed the feature/tarball-registry-mariadb-percona branch from 1b574a5 to 39e1468 Compare April 5, 2026 08:51
Percona Server (8.0.36-28, 8.4.2-2):
- Download from downloads.percona.com with glibc fallback
- Single sandbox + version verification (grep Percona)
- Replication + test_replication

MariaDB (10.11.25 LTS, 11.4.10 LTS):
- Download from downloads.mariadb.com
- Single sandbox + version verification (grep MariaDB)
- Replication with write→read data verification
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.github/workflows/integration_tests.yml (1)

217-217: Inconsistent replication verification delay.

This step uses sleep 2 while other replication tests in this workflow (lines 395, 545, 599, etc.) use sleep 3. The shorter delay could cause intermittent test failures if replication takes slightly longer.

-         sleep 2
+         sleep 3
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/integration_tests.yml at line 217, The workflow step
currently uses "sleep 2" which is inconsistent with other replication
verification steps and can cause intermittent failures; update that step to use
"sleep 3" (replace the "sleep 2" token with "sleep 3") so the delay matches the
other replication tests and allows enough time for replication to complete.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/integration_tests.yml:
- Around line 170-173: The workflow matrix for mariadb-version in
.github/workflows/integration_tests.yml currently lists '10.11.25' and
'11.4.10', which do not match the new registry entries added in the PR; update
the matrix key "mariadb-version" to include at least one of the actual registry
versions introduced (for example '10.11.11' or '11.4.5') so the new registry
entries are exercised by CI—modify the matrix.mariadb-version array to add or
replace a value with one of {10.6.21, 10.11.11, 11.4.5, 11.7.2, 11.8.1}.

---

Nitpick comments:
In @.github/workflows/integration_tests.yml:
- Line 217: The workflow step currently uses "sleep 2" which is inconsistent
with other replication verification steps and can cause intermittent failures;
update that step to use "sleep 3" (replace the "sleep 2" token with "sleep 3")
so the delay matches the other replication tests and allows enough time for
replication to complete.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 21788d61-4ae3-40d5-9b26-168a16acd742

📥 Commits

Reviewing files that changed from the base of the PR and between 39e1468 and cb2a8b8.

📒 Files selected for processing (1)
  • .github/workflows/integration_tests.yml

Comment on lines +170 to +173
matrix:
mariadb-version:
- '10.11.25'
- '11.4.10'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Test versions don't match the registry versions being added.

The PR adds MariaDB registry entries for versions 10.6.21, 10.11.11, 11.4.5, 11.7.2, and 11.8.1, but the tests use 10.11.25 and 11.4.10. This means the newly added registry entries aren't actually being tested.

Consider testing at least one version from the registry:

      matrix:
        mariadb-version:
-          - '10.11.25'
-          - '11.4.10'
+          - '10.11.11'
+          - '11.4.5'
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
matrix:
mariadb-version:
- '10.11.25'
- '11.4.10'
matrix:
mariadb-version:
- '10.11.11'
- '11.4.5'
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/integration_tests.yml around lines 170 - 173, The workflow
matrix for mariadb-version in .github/workflows/integration_tests.yml currently
lists '10.11.25' and '11.4.10', which do not match the new registry entries
added in the PR; update the matrix key "mariadb-version" to include at least one
of the actual registry versions introduced (for example '10.11.11' or '11.4.5')
so the new registry entries are exercised by CI—modify the
matrix.mariadb-version array to add or replace a value with one of {10.6.21,
10.11.11, 11.4.5, 11.7.2, 11.8.1}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant