Skip to content

BUG: MedNIST data partitioned differently for different seeds#138

Merged
wyli merged 1 commit into
Project-MONAI:masterfrom
adamaji:mednist-size
Mar 16, 2021
Merged

BUG: MedNIST data partitioned differently for different seeds#138
wyli merged 1 commit into
Project-MONAI:masterfrom
adamaji:mednist-size

Conversation

@adamaji

@adamaji adamaji commented Mar 13, 2021

Copy link
Copy Markdown
Contributor

Companion PR to Project-MONAI/MONAI#1761 that fixes a similar issue. The data lists in this notebook are not partitioned in the same way depending on the random seed. Instead of using np.random.random() serially to select indices, choose all the indices at once based on one np.random.shuffle.

Signed-off-by: Adam Aji <3487395+adamaji@users.noreply.github.com>
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli wyli merged commit 7d09d7f into Project-MONAI:master Mar 16, 2021
@adamaji adamaji deleted the mednist-size branch March 16, 2021 19:09
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
…t-MONAI#138)

Signed-off-by: Adam Aji <3487395+adamaji@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants