Skip to content

adding a multigpu test of TestFLMonaiAlgo#5327

Merged
wyli merged 20 commits into
Project-MONAI:devfrom
wyli:dist-test-algo
Oct 14, 2022
Merged

adding a multigpu test of TestFLMonaiAlgo#5327
wyli merged 20 commits into
Project-MONAI:devfrom
wyli:dist-test-algo

Conversation

@wyli

@wyli wyli commented Oct 13, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #5133

Description

adds a test

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli changed the title adding a multigpu tests adding a multigpu tests TestFLMonaiAlgo Oct 13, 2022
wyli added 6 commits October 13, 2022 22:30
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added 2 commits October 13, 2022 17:32
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Oct 13, 2022

Copy link
Copy Markdown
Contributor Author

/black

@wyli wyli marked this pull request as ready for review October 13, 2022 21:59
@wyli wyli changed the title adding a multigpu tests TestFLMonaiAlgo adding a multigpu test of TestFLMonaiAlgo Oct 13, 2022
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>

@holgerroth holgerroth left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added 3 commits October 14, 2022 09:16
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Oct 14, 2022

Copy link
Copy Markdown
Contributor Author

/build

wyli added 3 commits October 14, 2022 10:22
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Oct 14, 2022

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli enabled auto-merge (squash) October 14, 2022 10:33
@wyli wyli disabled auto-merge October 14, 2022 11:02
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Oct 14, 2022

Copy link
Copy Markdown
Contributor Author

/build

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Oct 14, 2022

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli enabled auto-merge (squash) October 14, 2022 14:44
@wyli wyli disabled auto-merge October 14, 2022 14:59
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Oct 14, 2022

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli enabled auto-merge (squash) October 14, 2022 16:58
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Oct 14, 2022

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli merged commit 988fc73 into Project-MONAI:dev Oct 14, 2022
wyli added a commit to wyli/MONAI that referenced this pull request Oct 15, 2022
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

Fixes Project-MONAI#5133

### Description
adds a test

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [x] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
@wyli wyli deleted the dist-test-algo branch October 15, 2022 11:54
bhashemian pushed a commit to JHancox/MONAI that referenced this pull request Oct 20, 2022
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

Fixes Project-MONAI#5133

### Description
adds a test

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [x] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
KumoLiu pushed a commit that referenced this pull request Nov 2, 2022
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

Fixes #5133

### Description
adds a test

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [x] New tests added to cover the changes.
- [x] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support multi-gpu training with MonaiAlgo

4 participants