Skip to content

fix bug in retina detector #5255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wyli merged 3 commits into from
Oct 3, 2022
Merged

fix bug in retina detector #5255

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d28dd5
fix bug in retina detector
Can-Zhao Oct 3, 2022
8fdc060
add docstring
Can-Zhao Oct 3, 2022
a7f3c3e
[MONAI] code formatting
monai-bot Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion monai/apps/detection/networks/retinanet_detector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,13 +318,17 @@ def set_regular_matcher(self, fg_iou_thresh: float, bg_iou_thresh: float, allow_
Args:
fg_iou_thresh: foreground IoU threshold for Matcher, considered as matched if IoU > fg_iou_thresh
bg_iou_thresh: background IoU threshold for Matcher, considered as not matched if IoU < bg_iou_thresh
allow_low_quality_matches: if True, produce additional matches
for predictions that have only low-quality match candidates.
"""
if fg_iou_thresh < bg_iou_thresh:
raise ValueError(
"Require fg_iou_thresh >= bg_iou_thresh. "
f"Got fg_iou_thresh={fg_iou_thresh}, bg_iou_thresh={bg_iou_thresh}."
)
self.proposal_matcher = Matcher(fg_iou_thresh, bg_iou_thresh, allow_low_quality_matches=True)
self.proposal_matcher = Matcher(
fg_iou_thresh, bg_iou_thresh, allow_low_quality_matches=allow_low_quality_matches
)

def set_atss_matcher(self, num_candidates: int = 4, center_in_gt: bool = False) -> None:
"""
Expand Down