Skip to content

HoVerNet Mode and Branch to independent StrEnum#5219

Merged
wyli merged 11 commits into
Project-MONAI:devfrom
bhashemian:hovernet-enums
Sep 30, 2022
Merged

HoVerNet Mode and Branch to independent StrEnum#5219
wyli merged 11 commits into
Project-MONAI:devfrom
bhashemian:hovernet-enums

Conversation

@bhashemian

@bhashemian bhashemian commented Sep 28, 2022

Copy link
Copy Markdown
Member

Fixes #5218

Description

This PR moves HoVerNet Mode and Branch outside of the module and make them independent StrEnums.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@bhashemian bhashemian requested a review from JHancox September 28, 2022 20:05
Comment thread monai/networks/nets/hovernet.py
@wyli wyli requested review from KumoLiu and Nic-Ma September 29, 2022 09:07
Comment thread monai/networks/nets/hovernet.py
Comment thread monai/networks/nets/hovernet.py Outdated
Comment thread monai/networks/nets/hovernet.py
@wyli

wyli commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

/build

Comment thread monai/networks/nets/hovernet.py Outdated
@wyli

wyli commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

/build

@wyli

wyli commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

/build

@wyli wyli enabled auto-merge (squash) September 30, 2022 14:26
@wyli wyli merged commit 607123b into Project-MONAI:dev Sep 30, 2022
@bhashemian bhashemian deleted the hovernet-enums branch September 30, 2022 18:14
@bhashemian bhashemian restored the hovernet-enums branch September 30, 2022 18:14
@bhashemian bhashemian deleted the hovernet-enums branch September 30, 2022 18:44
wyli pushed a commit that referenced this pull request Oct 10, 2022
Fixes #5218 

### Description

This PR moves `HoVerNet` Mode and Branch outside of the module and make
them independent `StrEnums`.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [x] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
KumoLiu pushed a commit that referenced this pull request Nov 2, 2022
Fixes #5218 

### Description

This PR moves `HoVerNet` Mode and Branch outside of the module and make
them independent `StrEnums`.

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [x] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [x] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [x] In-line docstrings updated.

Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: KumoLiu <yunl@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TorchScript not working with HoVerNet enum keys

3 participants