Skip to content

4715 update slicing impl.#4716

Merged
wyli merged 2 commits into
Project-MONAI:devfrom
wyli:4715-slicing
Jul 18, 2022
Merged

4715 update slicing impl.#4716
wyli merged 2 commits into
Project-MONAI:devfrom
wyli:4715-slicing

Conversation

@wyli

@wyli wyli commented Jul 16, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #4715

implementing slicing of a batch using decollate_batch

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from Nic-Ma and rijobro and removed request for rijobro July 16, 2022 17:12
@wyli wyli marked this pull request as ready for review July 16, 2022 17:43
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@Nic-Ma

Nic-Ma commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

Hi @KumoLiu ,

Could you please help verify the change in your sliding window test cases?

Thanks in advance.

@Nic-Ma Nic-Ma requested a review from KumoLiu July 18, 2022 07:15
@wyli

wyli commented Jul 18, 2022

Copy link
Copy Markdown
Contributor Author

Hi @KumoLiu ,

Could you please help verify the change in your sliding window test cases?

Thanks in advance.

Hi both, this one will not address the sliding window issue, please try #4714 sorry for the confusion.

@KumoLiu

KumoLiu commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

Hi @KumoLiu ,
Could you please help verify the change in your sliding window test cases?
Thanks in advance.

Hi both, this one will not address the sliding window issue, please try #4714 sorry for the confusion.

Hi @wyli @Nic-Ma ,
I have been tested by the changes in #4714. It can address the sliding window issue! Thanks!

@wyli

wyli commented Jul 18, 2022

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli enabled auto-merge (squash) July 18, 2022 16:35
@wyli wyli merged commit 5fb767c into Project-MONAI:dev Jul 18, 2022
@wyli wyli deleted the 4715-slicing branch July 18, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

metatensor slicing should decollate applied operations

3 participants