Skip to content

Preserve ordering of input dict's keys in crop transforms#4707

Merged
Nic-Ma merged 2 commits into
Project-MONAI:devfrom
KumoLiu:preserving-order-of-the-keys-during-transform
Jul 15, 2022
Merged

Preserve ordering of input dict's keys in crop transforms#4707
Nic-Ma merged 2 commits into
Project-MONAI:devfrom
KumoLiu:preserving-order-of-the-keys-during-transform

Conversation

@KumoLiu

@KumoLiu KumoLiu commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: KumoLiu yunl@nvidia.com

Fixes # .

Description

Preserve ordering of input dict's keys in crop transforms from test error (Project-MONAI/tutorials#791)

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: KumoLiu <yunl@nvidia.com>
@KumoLiu KumoLiu requested review from Nic-Ma and wyli July 15, 2022 11:17
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

/build

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @KumoLiu ,

Looks good to me.
Could you please help also the test cases to the crop_by_pos_neg_labels:
https://github.com/Project-MONAI/MONAI/blob/dev/tests/test_rand_crop_by_pos_neg_labeld.py

Thanks.

@KumoLiu

KumoLiu commented Jul 15, 2022

Copy link
Copy Markdown
Contributor Author

Hi @KumoLiu ,

Looks good to me. Could you please help also the test cases to the crop_by_pos_neg_labels: https://github.com/Project-MONAI/MONAI/blob/dev/tests/test_rand_crop_by_pos_neg_labeld.py

Thanks.

Yes, but it seems it had been added before.

@Nic-Ma Nic-Ma enabled auto-merge (squash) July 15, 2022 12:36
@Nic-Ma Nic-Ma merged commit def0d90 into Project-MONAI:dev Jul 15, 2022
@KumoLiu KumoLiu deleted the preserving-order-of-the-keys-during-transform branch July 20, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants