Skip to content

4667 Enhance verify metadata#4686

Merged
Nic-Ma merged 3 commits into
Project-MONAI:devfrom
yiheng-wang-nv:4667-enhance-bundle-verify-metadata
Jul 13, 2022
Merged

4667 Enhance verify metadata#4686
Nic-Ma merged 3 commits into
Project-MONAI:devfrom
yiheng-wang-nv:4667-enhance-bundle-verify-metadata

Conversation

@yiheng-wang-nv

@yiheng-wang-nv yiheng-wang-nv commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Yiheng Wang vennw@nvidia.com

Fixes #4667

Description

This PR is used to enhance the verify metadata function for monai.bundle.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@yiheng-wang-nv yiheng-wang-nv requested a review from Nic-Ma July 13, 2022 09:38
@yiheng-wang-nv yiheng-wang-nv marked this pull request as ready for review July 13, 2022 09:38
@yiheng-wang-nv yiheng-wang-nv changed the title 4667 Enhance verify metadata and dynunet docstring 4667 Enhance verify metadata Jul 13, 2022
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@Nic-Ma

Nic-Ma commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

/build

Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@Nic-Ma

Nic-Ma commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) July 13, 2022 11:16
@Nic-Ma Nic-Ma merged commit 3b12a24 into Project-MONAI:dev Jul 13, 2022
@yiheng-wang-nv yiheng-wang-nv deleted the 4667-enhance-bundle-verify-metadata branch July 13, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bundle.verify_metadata does not raise ValidationError

2 participants