Skip to content

4649 adds __array_function__ impl.#4676

Merged
wyli merged 10 commits into
Project-MONAI:devfrom
wyli:metatensor-array
Jul 13, 2022
Merged

4649 adds __array_function__ impl.#4676
wyli merged 10 commits into
Project-MONAI:devfrom
wyli:metatensor-array

Conversation

@wyli

@wyli wyli commented Jul 11, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #4649

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from Nic-Ma, ericspod and rijobro July 11, 2022 21:45
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the metatensor-array branch from 92377a6 to 1a6c3c8 Compare July 11, 2022 22:06
Comment thread monai/data/meta_tensor.py Outdated
wyli and others added 8 commits July 12, 2022 08:23
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review July 12, 2022 21:18
@wyli wyli requested a review from ericspod July 12, 2022 21:19
@wyli

wyli commented Jul 13, 2022

Copy link
Copy Markdown
Contributor Author

Hi @Nic-Ma please help review this PR

Comment thread monai/data/meta_tensor.py
@wyli

wyli commented Jul 13, 2022

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli enabled auto-merge (squash) July 13, 2022 16:24
@wyli wyli merged commit 57f3999 into Project-MONAI:dev Jul 13, 2022
@wyli wyli deleted the metatensor-array branch July 19, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interoperability numpy functions <> MetaTensor

3 participants