Skip to content

add box selector#4437

Merged
wyli merged 10 commits into
Project-MONAI:devfrom
Can-Zhao:box_selector
Jun 2, 2022
Merged

add box selector#4437
wyli merged 10 commits into
Project-MONAI:devfrom
Can-Zhao:box_selector

Conversation

@Can-Zhao

@Can-Zhao Can-Zhao commented Jun 1, 2022

Copy link
Copy Markdown
Collaborator

Signed-off-by: Can Zhao canz@nvidia.com

Fixes #3576. Fix #4416.

Description

split box selection in detection inference out into BoxSelector
make box coder more general (not used in retinanet, but might be used in faster rcnn)
add batch nms

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Can-Zhao and others added 4 commits June 1, 2022 17:22
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao Can-Zhao added this to the Detection module [P0] milestone Jun 1, 2022
@Can-Zhao Can-Zhao marked this pull request as ready for review June 1, 2022 21:38
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao Can-Zhao requested review from Nic-Ma, mibaumgartner and wyli June 1, 2022 21:44
Can-Zhao added 3 commits June 1, 2022 17:47
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utilities for selecting candidate boxes

@wyli

wyli commented Jun 1, 2022

Copy link
Copy Markdown
Contributor

/build

@wyli wyli enabled auto-merge (squash) June 1, 2022 22:01
Signed-off-by: Can Zhao <canz@nvidia.com>
@wyli

wyli commented Jun 1, 2022

Copy link
Copy Markdown
Contributor

/build

Signed-off-by: Can Zhao <canz@nvidia.com>
@Nic-Ma

Nic-Ma commented Jun 2, 2022

Copy link
Copy Markdown
Contributor

/build

Comment thread monai/apps/detection/utils/box_selector.py
@wyli wyli merged commit bbc628d into Project-MONAI:dev Jun 2, 2022
@Can-Zhao Can-Zhao deleted the box_selector branch June 2, 2022 02:50
@Can-Zhao Can-Zhao mentioned this pull request Jun 2, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add batch_nms to box util Box selector

3 participants