Foreground Tissue Mask#4379
Conversation
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Nic-Ma
left a comment
There was a problem hiding this comment.
Thanks for the new feature, it overall looks good to me, put some minor comments inline.
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
There was a problem hiding this comment.
Thanks for the quick update, it overall looks good to me.
Put some minor comments inline.
As it's a typical use case for images and in the core transforms, could you please help add the sample image in the doc? Following: https://github.com/Project-MONAI/MONAI/blob/dev/monai/transforms/utils_create_transform_ims.py
Thanks.
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
@Nic-Ma, I think it has the same blocker that has not been resolved: #4161 |
|
Thanks for the quick update. Thanks in advance. |
|
HI @Nic-Ma, alright, let me see if I can create an image with the existing data for this transform. |
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
Signed-off-by: Behrooz <3968947+drbeh@users.noreply.github.com>
|
@Nic-Ma, I've added the images for this transform: Project-MONAI/DocImages#12, and updated this PR. Can you check they are fine? |
Nic-Ma
left a comment
There was a problem hiding this comment.
Thanks for the quick update!
Looks good to me.
Thanks.
|
/black |
|
/build |
Fixes #4380
Prerequisite for #4014
Description
This PR implements
ForegroundMasktransform that creates a foreground mask with various thresholding. For digital pathology use cases, this transform is helpful to create sliding-window patches that covers only the tissue.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.