add anchor generators used for detection#4336
Merged
Merged
Conversation
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
for more information, see https://pre-commit.ci
wyli
reviewed
May 25, 2022
wyli
left a comment
Contributor
There was a problem hiding this comment.
could you please add some unit tests for this module?
Signed-off-by: Can Zhao <canz@nvidia.com>
for more information, see https://pre-commit.ci
Collaborator
Author
Thanks. Just added |
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Contributor
|
/build |
- torchvision compatibility - torchscript compatibility Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
|
fyi, some issues with torch 1.7/1.8 from tests: Details |
Contributor
|
/build |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
|
/build |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
|
/build |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
for more information, see https://pre-commit.ci
wyli
reviewed
May 30, 2022
Contributor
|
/build |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
|
/build |
mibaumgartner
left a comment
Collaborator
There was a problem hiding this comment.
Left some small notes, the rest looks good to me.
for more information, see https://pre-commit.ci
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Can Zhao canz@nvidia.com
Fixes #3573 .
Description
add anchor generators used for detection
Status
Ready/Work in progress/Hold
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.