Skip to content

add hard_negative_sampler.py for detection#4301

Merged
wyli merged 33 commits into
Project-MONAI:devfrom
Can-Zhao:detection_net
May 31, 2022
Merged

add hard_negative_sampler.py for detection#4301
wyli merged 33 commits into
Project-MONAI:devfrom
Can-Zhao:detection_net

Conversation

@Can-Zhao

@Can-Zhao Can-Zhao commented May 20, 2022

Copy link
Copy Markdown
Collaborator

Signed-off-by: Can Zhao canz@nvidia.com

Fixes #4300.

Fixes #4405

Description

add hard_negative_sampler.py
make it a general sampler for classification tasks.
add unit test

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Can-Zhao added 3 commits May 19, 2022 22:40
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao Can-Zhao added this to the Detection module [P0] milestone May 20, 2022
@Can-Zhao Can-Zhao requested review from Nic-Ma and wyli May 20, 2022 02:45
@Can-Zhao Can-Zhao marked this pull request as ready for review May 20, 2022 02:46
Comment thread monai/apps/detection/hard_negative_sampler.py Outdated
Comment thread monai/apps/detection/hard_negative_sampler.py Outdated
Can-Zhao and others added 4 commits May 19, 2022 22:52
@Can-Zhao

Copy link
Copy Markdown
Collaborator Author

/black

@wyli

wyli commented May 20, 2022

Copy link
Copy Markdown
Contributor

Cc @mibaumgartner @dongyang0122 could you please have a look if you have time? this is part of the detection pipeline.

Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao Can-Zhao marked this pull request as draft May 21, 2022 00:13
Comment thread monai/apps/detection/hard_negative_sampler.py Outdated
Comment thread monai/apps/detection/hard_negative_sampler.py Outdated
Can-Zhao and others added 4 commits May 27, 2022 12:10
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
@Can-Zhao Can-Zhao marked this pull request as ready for review May 27, 2022 18:30
@Can-Zhao

Copy link
Copy Markdown
Collaborator Author

/black

Can-Zhao and others added 10 commits May 27, 2022 14:36
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Can Zhao <canz@nvidia.com>

@mibaumgartner mibaumgartner left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Comment thread monai/apps/detection/utils/hard_negative_sampler.py
Can-Zhao and others added 6 commits May 30, 2022 12:06
Signed-off-by: Can Zhao <canz@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this adds indices samplers based on the predictive scores.

@wyli

wyli commented May 31, 2022

Copy link
Copy Markdown
Contributor

/build

@wyli wyli enabled auto-merge (squash) May 31, 2022 07:51
@wyli wyli merged commit a75dd05 into Project-MONAI:dev May 31, 2022
@Can-Zhao Can-Zhao deleted the detection_net branch June 1, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

integration error tests.test_retinanet Add HardNegativeSampler to suppress false positive, especially in detection

5 participants