4172 aggregate with buffer copy#4174
Merged
Merged
Conversation
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
Author
|
/build |
Nic-Ma
approved these changes
Apr 26, 2022
Nic-Ma
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the quick fix.
Contributor
|
Mark: may also cover #4176 in this PR. Thanks. |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
Author
|
/build |
Contributor
Author
|
/build |
Can-Zhao
pushed a commit
to Can-Zhao/MONAI
that referenced
this pull request
May 10, 2022
* fixes Project-MONAI#4172 aggregate with no in-place buffer change Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update reduction option Signed-off-by: Wenqi Li <wenqil@nvidia.com> * fixes flake8 Signed-off-by: Wenqi Li <wenqil@nvidia.com> * update Signed-off-by: Wenqi Li <wenqil@nvidia.com> * adds tests Signed-off-by: Wenqi Li <wenqil@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li wenqil@nvidia.com
Fixes #4172
Fixes #4176
Description
copy the buffer when aggregating.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.