Skip to content

4160 Enhance mean dice#4163

Merged
wyli merged 3 commits into
Project-MONAI:devfrom
yiheng-wang-nv:4160-enhance-mean-dice
Apr 29, 2022
Merged

4160 Enhance mean dice#4163
wyli merged 3 commits into
Project-MONAI:devfrom
yiheng-wang-nv:4160-enhance-mean-dice

Conversation

@yiheng-wang-nv

Copy link
Copy Markdown
Contributor

Signed-off-by: Yiheng Wang vennw@nvidia.com

Fixes #4160 .

Description

This PR enhances the DiceMetric via adding an option to handle the empty ground truth cases.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

yiheng-wang-nv and others added 2 commits April 24, 2022 14:36
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
@Nic-Ma

Nic-Ma commented Apr 24, 2022

Copy link
Copy Markdown
Contributor

Would be necessary to also this option in other metrics? I am not sure about that.
Need @dongyang0122 @ericspod @wyli @holgerroth to help evaluate from the research use cases angle.

Thanks in advance.

@ericspod

Copy link
Copy Markdown
Member

I stated in the original issue before noticing this, but with the dice loss we have two distinct values for smoothing the numerator and denominator which can be set to allow the user to select which way to handle empty ground truths. I think we should have the same solution here for consistency rather than a special case for when the ground truth is empty.

Comment thread monai/metrics/meandice.py

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change improves the current dev codebase.

@wyli

wyli commented Apr 29, 2022

Copy link
Copy Markdown
Contributor

/build

@wyli wyli enabled auto-merge (squash) April 29, 2022 06:48
@wyli

wyli commented Apr 29, 2022

Copy link
Copy Markdown
Contributor

/build

@wyli wyli merged commit 9af6332 into Project-MONAI:dev Apr 29, 2022
Can-Zhao pushed a commit to Can-Zhao/MONAI that referenced this pull request May 10, 2022
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance DiceMetric to support counting negative samples

4 participants