Skip to content

4010 4016 fixes mmar integration tests#4021

Merged
wyli merged 9 commits into
devfrom
4010-mmar
Mar 30, 2022
Merged

4010 4016 fixes mmar integration tests#4021
wyli merged 9 commits into
devfrom
4010-mmar

Conversation

@wyli

@wyli wyli commented Mar 29, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #4010
Fixes #4016
adds pytorch:21.10 regular tests

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 8 commits March 28, 2022 14:05
@wyli
fixes unit test
b78b390 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
temp tests
238d883 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
adds docker version tests
d4616d1 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
fixes #4016
df2756e 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
local tests
ae24c2b 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
remove mmar cache daily
463d657 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
remove cache
1b5a4ce 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli
Revert "temp tests"
f578045 
This reverts commit 238d883.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli changed the title 4010 mmar 4010 4016 fixes mmar integration tests Mar 29, 2022
@wyli
fixes typo
d47e0ae 
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review March 29, 2022 10:59
@wyli

wyli commented Mar 29, 2022

Copy link
Copy Markdown
Contributor Author

verified here https://github.com/Project-MONAI/MONAI/actions/runs/2057618131

@wyli

wyli commented Mar 29, 2022

Copy link
Copy Markdown
Contributor Author

/build

Nic-Ma
Nic-Ma reviewed Mar 29, 2022
View reviewed changes
Comment thread tests/test_mmar_download.py
@wyli wyli merged commit df19315 into dev Mar 30, 2022
@wyli wyli deleted the 4010-mmar branch March 30, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes
@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv
@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner
@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

pylint error after update integration test error: test_mmar_download

2 participants

@wyli @Nic-Ma