Skip to content

3914 optional lps to ras#3929

Merged
wyli merged 4 commits into
Project-MONAI:devfrom
wyli:3914-optional-flip
Mar 14, 2022
Merged

3914 optional lps to ras#3929
wyli merged 4 commits into
Project-MONAI:devfrom
wyli:3914-optional-flip

Conversation

@wyli

@wyli wyli commented Mar 14, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #3914

Description

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli

wyli commented Mar 14, 2022

Copy link
Copy Markdown
Contributor Author

/black

@wyli wyli marked this pull request as ready for review March 14, 2022 12:37

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Do we also need to change image writers for this problem?

Thanks.

@wyli

wyli commented Mar 14, 2022

Copy link
Copy Markdown
Contributor Author

/build

wyli added 3 commits March 14, 2022 17:08
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 3914-optional-flip branch from e225969 to f5a6478 Compare March 14, 2022 17:08
@wyli

wyli commented Mar 14, 2022

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli enabled auto-merge (squash) March 14, 2022 17:35
@wyli wyli disabled auto-merge March 14, 2022 17:43
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Mar 14, 2022

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli enabled auto-merge (squash) March 14, 2022 18:40
@wyli wyli merged commit d8121d2 into Project-MONAI:dev Mar 14, 2022
@wyli wyli deleted the 3914-optional-flip branch March 14, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ITKReader silently changes the affine matrix to RAS without informing the users

3 participants