Skip to content

3904 improve output_transform of handlers#3913

Merged
Nic-Ma merged 9 commits into
Project-MONAI:devfrom
Nic-Ma:3904-improve-output
Mar 12, 2022
Merged

3904 improve output_transform of handlers#3913
Nic-Ma merged 9 commits into
Project-MONAI:devfrom
Nic-Ma:3904-improve-output

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Mar 9, 2022

Copy link
Copy Markdown
Contributor

Fixes #3904 .

Description

This PR added the ignore_data API to improve user experience when avoiding logging with lambda x: None in handlers.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

/integration-test

@Nic-Ma

Nic-Ma commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

I already verified the workflow integration test locally.

Thanks.

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli March 9, 2022 15:32
@Nic-Ma

Nic-Ma commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma changed the title 3904 improve output_transform of handlers [WIP] 3904 improve output_transform of handlers Mar 10, 2022
Signed-off-by: Nic Ma <nma@nvidia.com>

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I think the API becomes intuitive now

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma changed the title [WIP] 3904 improve output_transform of handlers 3904 improve output_transform of handlers Mar 12, 2022
@Nic-Ma

Nic-Ma commented Mar 12, 2022

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Mar 12, 2022

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) March 12, 2022 11:22
@Nic-Ma Nic-Ma merged commit 7587e71 into Project-MONAI:dev Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve output_transform for StatsHandler

2 participants