3432 make vit support torchscript#3782
Merged
wyli merged 5 commits intoFeb 10, 2022
Merged
Conversation
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Contributor
|
some typing issue here https://github.com/Project-MONAI/MONAI/runs/5122538609?check_suite_focus=true#step:7:21211 |
Member
|
There may be some deep-seated incompatibilities between Torchscript and Einops: arogozhnikov/einops#115 The issue with |
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
Contributor
|
/build |
wyli
pushed a commit
to wyli/MONAI
that referenced
this pull request
Feb 10, 2022
* make vit support torchscript Signed-off-by: Yiheng Wang <vennw@nvidia.com> * add torch version restriction Signed-off-by: Yiheng Wang <vennw@nvidia.com> * change skip decorator order Signed-off-by: Yiheng Wang <vennw@nvidia.com> * remove extra cls Signed-off-by: Yiheng Wang <vennw@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yiheng Wang vennw@nvidia.com
Fixes #3432 .
Description
This PR is used to fix #3422 , different from the way used in #3433 which requires to remove
einops, this PR keeps this library.During this PR, the direct calling of
einops.arrangein forward functions ofclass SABlockhas been replaced by usingRearrangelayers in order to support torchscript.Status
Ready/Work in progress/Hold
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.