Skip to content

3734 Enhance CacheDataset to avoid duplicated cache#3739

Merged
Nic-Ma merged 16 commits into
Project-MONAI:devfrom
Nic-Ma:3734-add-hashid-cache
Feb 1, 2022
Merged

3734 Enhance CacheDataset to avoid duplicated cache#3739
Nic-Ma merged 16 commits into
Project-MONAI:devfrom
Nic-Ma:3734-add-hashid-cache

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Jan 29, 2022

Copy link
Copy Markdown
Contributor

Fixes #3734 .

Description

This PR enhancedCacheDataset to avoid caching duplicated content for the augmented dataset.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Jan 29, 2022

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Jan 29, 2022

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli January 29, 2022 08:38
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Jan 29, 2022

Copy link
Copy Markdown
Contributor Author

/build

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Jan 29, 2022

Copy link
Copy Markdown
Contributor Author

/build

Comment thread monai/data/dataset.py Outdated
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma force-pushed the 3734-add-hashid-cache branch from e1b0ede to b57a755 Compare January 30, 2022 04:02
@Nic-Ma

Nic-Ma commented Jan 30, 2022

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Jan 30, 2022

Copy link
Copy Markdown
Contributor Author

/build

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@Nic-Ma

Nic-Ma commented Jan 30, 2022

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma

Nic-Ma commented Jan 30, 2022

Copy link
Copy Markdown
Contributor Author

Mark: autoformat is updated, so /black introduced some extra change in this PR.

Thanks.

@wyli

wyli commented Jan 30, 2022

Copy link
Copy Markdown
Contributor

Sure, I'll separate the style changes into another style PR...

@Nic-Ma Nic-Ma changed the title 3734 Add HashCacheDataset to avoid duplicated cache 3734 Enhance CacheDataset to avoid duplicated cache Jan 30, 2022
@Nic-Ma

Nic-Ma commented Jan 30, 2022

Copy link
Copy Markdown
Contributor Author

/build

Comment thread monai/data/dataset.py Outdated
Comment thread monai/data/dataset.py Outdated
Comment thread monai/data/dataset.py Outdated
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Jan 31, 2022

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Jan 31, 2022

Copy link
Copy Markdown
Contributor Author

/build

@wyli

wyli commented Jan 31, 2022

Copy link
Copy Markdown
Contributor

/build

2 similar comments
@Nic-Ma

Nic-Ma commented Feb 1, 2022

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma

Nic-Ma commented Feb 1, 2022

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma

Nic-Ma commented Feb 1, 2022

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) February 1, 2022 13:19
@Nic-Ma

Nic-Ma commented Feb 1, 2022

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma merged commit 6f16823 into Project-MONAI:dev Feb 1, 2022
wyli added a commit that referenced this pull request Feb 9, 2022
* [DLMED] add HashCacheDataset

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] add more test

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] skip min test

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix flake8

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

* [MONAI] python code formatting

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Co-authored-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request Feb 9, 2022
* [DLMED] add HashCacheDataset

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] add more test

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] skip min test

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix flake8

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

* [MONAI] python code formatting

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Co-authored-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request Feb 9, 2022
* [DLMED] add HashCacheDataset

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] add more test

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] skip min test

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix flake8

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

* [MONAI] python code formatting

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Co-authored-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request Feb 9, 2022
* [DLMED] add HashCacheDataset

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] add more test

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] skip min test

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix flake8

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

* [MONAI] python code formatting

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <nma@nvidia.com>

Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
Co-authored-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid duplicated cache content in CacheDataset

3 participants