Skip to content

support stack of images with channels#3680

Merged
wyli merged 4 commits into
Project-MONAI:devfrom
wyli:update-stack
Jan 20, 2022
Merged

support stack of images with channels#3680
wyli merged 4 commits into
Project-MONAI:devfrom
wyli:update-stack

Conversation

@wyli

@wyli wyli commented Jan 19, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Wenqi Li wenqil@nvidia.com

adding the support of stacking at the channel dimension for image reader.
This could be useful for loading multiple single-channel data with shape
[(42, 42, 1), (42, 42, 1), (42, 42, 1)]

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from Nic-Ma, ericspod and rijobro January 19, 2022 15:55

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for some minor comments.
So I think the main purpose of this PR is to add the concat logic for images with channel?

Thanks.

Comment thread monai/data/image_reader.py Outdated
wyli added 3 commits January 20, 2022 00:17
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Jan 20, 2022

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli enabled auto-merge (squash) January 20, 2022 00:25
@wyli wyli merged commit 50c201c into Project-MONAI:dev Jan 20, 2022
wyli added a commit that referenced this pull request Jan 21, 2022
* support stack of images with channels

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added a commit that referenced this pull request Jan 21, 2022
* support stack of images with channels

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update based on comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli deleted the update-stack branch April 27, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants