Skip to content

3643 update meshgrid#3644

Merged
wyli merged 2 commits into
Project-MONAI:devfrom
wyli:3643-meshgrid-ij
Jan 12, 2022
Merged

3643 update meshgrid#3644
wyli merged 2 commits into
Project-MONAI:devfrom
wyli:3643-meshgrid-ij

Conversation

@wyli

@wyli wyli commented Jan 11, 2022

Copy link
Copy Markdown
Contributor

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #3643

Description

meshgrid with the indexing option

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review January 12, 2022 08:12
@wyli

wyli commented Jan 12, 2022

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@ericspod Do you have any other comments?

Thanks in advance.

@wyli

wyli commented Jan 12, 2022

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli enabled auto-merge (squash) January 12, 2022 10:54
@ericspod

ericspod commented Jan 12, 2022

Copy link
Copy Markdown
Member

Looks good to me. This will reduce the number of warnings Pytorch brings up.

@wyli

wyli commented Jan 12, 2022

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli merged commit d58e234 into Project-MONAI:dev Jan 12, 2022
@wyli wyli deleted the 3643-meshgrid-ij branch April 27, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warning using RandAffined. torch.meshgrid: pass the indexing argument

3 participants