Fix differentiability of generalized Dice loss#3619
Merged
wyli merged 4 commits intoJan 24, 2022
Merged
Conversation
Signed-off-by: Josafat-Mattias Burmeister <josafat-mattias.burmeister@student.hpi.de>
Signed-off-by: Josafat-Mattias Burmeister <josafat-mattias.burmeister@student.hpi.de>
wyli
reviewed
Jan 9, 2022
…generalized-dice-loss Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli
approved these changes
Jan 24, 2022
Contributor
|
/build |
1 similar comment
Contributor
|
/build |
wyli
added a commit
that referenced
this pull request
Feb 9, 2022
* fix differentiability of generalized Dice loss Signed-off-by: Josafat-Mattias Burmeister <josafat-mattias.burmeister@student.hpi.de> * fix weight clamping for the case that is True Signed-off-by: Josafat-Mattias Burmeister <josafat-mattias.burmeister@student.hpi.de> * add test case for batch mode Co-authored-by: Wenqi Li <wenqil@nvidia.com>
wyli
added a commit
that referenced
this pull request
Feb 9, 2022
* fix differentiability of generalized Dice loss Signed-off-by: Josafat-Mattias Burmeister <josafat-mattias.burmeister@student.hpi.de> * fix weight clamping for the case that is True Signed-off-by: Josafat-Mattias Burmeister <josafat-mattias.burmeister@student.hpi.de> * add test case for batch mode Co-authored-by: Wenqi Li <wenqil@nvidia.com>
wyli
added a commit
that referenced
this pull request
Feb 9, 2022
* fix differentiability of generalized Dice loss Signed-off-by: Josafat-Mattias Burmeister <josafat-mattias.burmeister@student.hpi.de> * fix weight clamping for the case that is True Signed-off-by: Josafat-Mattias Burmeister <josafat-mattias.burmeister@student.hpi.de> * add test case for batch mode Co-authored-by: Wenqi Li <wenqil@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Josafat-Mattias Burmeister josafat-mattias.burmeister@student.hpi.de
Fixes #3618.
Description
Replaces the weight clamp code in the forward method of the GeneralizedDiceLoss module with an equivalent differentiable version.
Status
Ready
I was not able to run the tests locally as some tests that do not seem to be related to my changes failed. Since the tests passed in the CI pipeline, I marked this PR as ready.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.