Skip to content

3609 - conda environment-dev.yml test#3612

Merged
wyli merged 13 commits into
devfrom
conda-test
Jan 9, 2022
Merged

3609 - conda environment-dev.yml test#3612
wyli merged 13 commits into
devfrom
conda-test

Conversation

@wyli

@wyli wyli commented Jan 8, 2022

Copy link
Copy Markdown
Contributor

Fixes #3609

Description

adding a daily test for the conda env file

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 8 commits January 8, 2022 12:42
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli requested review from Nic-Ma and rijobro January 8, 2022 16:11
@wyli

wyli commented Jan 8, 2022

Copy link
Copy Markdown
Contributor Author

@wyli wyli marked this pull request as ready for review January 8, 2022 16:12
@wyli wyli requested a review from ericspod January 8, 2022 16:25

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@rijobro @IsaacYangSLA , do you have any other comments?

Thanks.

@Nic-Ma Nic-Ma requested a review from IsaacYangSLA January 8, 2022 17:06
@wyli wyli marked this pull request as draft January 8, 2022 21:09
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the conda-test branch 2 times, most recently from aa4b4a3 to 476998b Compare January 9, 2022 11:06
wyli added 2 commits January 9, 2022 19:44
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli marked this pull request as ready for review January 9, 2022 19:48
@wyli

wyli commented Jan 9, 2022

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli enabled auto-merge (squash) January 9, 2022 20:23
@wyli wyli merged commit e163992 into dev Jan 9, 2022
@wyli wyli deleted the conda-test branch January 9, 2022 21:11
Can-Zhao pushed a commit to Can-Zhao/MONAI that referenced this pull request Jan 10, 2022
* adds a conda test

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* openslide windows

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* conda create

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes lmdb

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes windows paging

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes matplotlib version

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes openslide conda

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* remove temp tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* try to fix windows paging

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update cpuonly tests

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* fixes windows install

Signed-off-by: Wenqi Li <wenqil@nvidia.com>

* update comments

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test conda environment-dev.yml

2 participants