Skip to content

3314 Fix FC layer issue in ResNet#3324

Merged
Nic-Ma merged 8 commits into
Project-MONAI:devfrom
Nic-Ma:3314-fix-resnet
Nov 12, 2021
Merged

3314 Fix FC layer issue in ResNet#3324
Nic-Ma merged 8 commits into
Project-MONAI:devfrom
Nic-Ma:3314-fix-resnet

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Nov 12, 2021

Copy link
Copy Markdown
Contributor

Fixes #3314 .

Description

This PR fixed the FC layer missing issue in ResNet and added unit tests to cover it.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Nov 12, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Nov 12, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) November 12, 2021 03:01
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Nov 12, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma merged commit 5c8f3bb into Project-MONAI:dev Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ResNet class does not respect argument feed_forward=False

2 participants