Skip to content

Add affine param to Affine transform (#3313)#3318

Merged
Nic-Ma merged 3 commits into
Project-MONAI:devfrom
Spenhouet:feature/3313-affine-param
Nov 12, 2021
Merged

Add affine param to Affine transform (#3313)#3318
Nic-Ma merged 3 commits into
Project-MONAI:devfrom
Spenhouet:feature/3313-affine-param

Conversation

@Spenhouet

Copy link
Copy Markdown
Contributor

Signed-off-by: Sebastian Penhouet s.penhouet@outlook.de

Fixes #3313 .

Description

Add the affine parameter to the Affine transform.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • In-line docstrings updated.

Signed-off-by: Sebastian Penhouet <sebastian.penhouet@airamed.de>
@Spenhouet Spenhouet force-pushed the feature/3313-affine-param branch from 26e1007 to 11e088c Compare November 11, 2021 15:43
wyli
wyli previously requested changes Nov 11, 2021

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's pending discussions in #3313

@wyli wyli dismissed their stale review November 11, 2021 17:59

(allows for the other core reviewers to decide)

@wyli wyli requested review from Nic-Ma and ericspod November 11, 2021 17:59
@Nic-Ma

Nic-Ma commented Nov 11, 2021

Copy link
Copy Markdown
Contributor

Thanks for the great discussions.

I will try to think about it again and review it ASAP tomorrow.

Thanks for the contribution!

@wyli wyli requested a review from rijobro November 11, 2021 17:59
@Nic-Ma

Nic-Ma commented Nov 11, 2021

Copy link
Copy Markdown
Contributor

/build

@Nic-Ma

Nic-Ma commented Nov 12, 2021

Copy link
Copy Markdown
Contributor

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) November 12, 2021 02:41
@Nic-Ma

Nic-Ma commented Nov 12, 2021

Copy link
Copy Markdown
Contributor

/build

1 similar comment
@Nic-Ma

Nic-Ma commented Nov 12, 2021

Copy link
Copy Markdown
Contributor

/build

@Nic-Ma

Nic-Ma commented Nov 12, 2021

Copy link
Copy Markdown
Contributor

/build

@Nic-Ma Nic-Ma merged commit 6f657a4 into Project-MONAI:dev Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Affine transform currently does not have an affine matrix parameter

3 participants