Skip to content

3212 3243 Add utility to check missing files in datalist#3247

Merged
Nic-Ma merged 11 commits into
Project-MONAI:devfrom
Nic-Ma:3212-add-datalist-check
Nov 3, 2021
Merged

3212 3243 Add utility to check missing files in datalist#3247
Nic-Ma merged 11 commits into
Project-MONAI:devfrom
Nic-Ma:3212-add-datalist-check

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Nov 3, 2021

Copy link
Copy Markdown
Contributor

Fixes #3212 #3243 .

Description

This PR added the utility function to check missing files of Decathlon datalist before training.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

/build

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma changed the title 3212 Add utility to check missing files in datalist 3212 3243 Add utility to check missing files in datalist Nov 3, 2021
@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli November 3, 2021 14:58
Comment thread monai/data/decathlon_datalist.py Outdated
Comment thread monai/data/decathlon_datalist.py Outdated
Comment thread monai/data/decathlon_datalist.py

@ericspod ericspod left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine with just a minor concern about absolute paths.

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) November 3, 2021 16:00
@Nic-Ma Nic-Ma merged commit 02efc60 into Project-MONAI:dev Nov 3, 2021
Comment thread monai/data/decathlon_datalist.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add utility to check missing images in Decathlon datalist

3 participants