Skip to content

Enhance rescale_array#3246

Merged
Nic-Ma merged 9 commits into
Project-MONAI:devfrom
Nic-Ma:enhance-rescale-array
Nov 3, 2021
Merged

Enhance rescale_array#3246
Nic-Ma merged 9 commits into
Project-MONAI:devfrom
Nic-Ma:enhance-rescale-array

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Nov 2, 2021

Copy link
Copy Markdown
Contributor

Follow up of #3235

Description

This PR added conversion for the output in rescale_array.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli November 2, 2021 23:22
@Nic-Ma Nic-Ma mentioned this pull request Nov 2, 2021
7 tasks
@Nic-Ma

Nic-Ma commented Nov 2, 2021

Copy link
Copy Markdown
Contributor Author

/build

Comment thread monai/transforms/utils.py Outdated
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma requested a review from ericspod November 3, 2021 00:19

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@Nic-Ma Nic-Ma enabled auto-merge (squash) November 3, 2021 10:45
@Nic-Ma

Nic-Ma commented Nov 3, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma merged commit ca15762 into Project-MONAI:dev Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants