Skip to content

3192 adds plot util#3193

Merged
wyli merged 17 commits into
Project-MONAI:devfrom
wyli:adds-vis
Nov 1, 2021
Merged

3192 adds plot util#3193
wyli merged 17 commits into
Project-MONAI:devfrom
wyli:adds-vis

Conversation

@wyli

@wyli wyli commented Oct 26, 2021

Copy link
Copy Markdown
Contributor

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #3192

Description

Figure_1
Figure_2

Status

ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 5 commits October 28, 2021 21:40
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
wyli added 2 commits October 30, 2021 14:57
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Oct 30, 2021

Copy link
Copy Markdown
Contributor Author

/build

wyli added 2 commits October 30, 2021 22:36
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Oct 30, 2021

Copy link
Copy Markdown
Contributor Author

/build

1 similar comment
@wyli

wyli commented Oct 30, 2021

Copy link
Copy Markdown
Contributor Author

/build

@wyli

wyli commented Oct 30, 2021

Copy link
Copy Markdown
Contributor Author

/build

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Oct 30, 2021

Copy link
Copy Markdown
Contributor Author

/build

@wyli

wyli commented Oct 31, 2021

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli marked this pull request as ready for review October 31, 2021 09:42
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Comment thread tests/test_matshow3d.py Outdated
@wyli

wyli commented Oct 31, 2021

Copy link
Copy Markdown
Contributor Author

/build

Comment thread monai/visualize/utils.py Outdated
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Oct 31, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma

Nic-Ma commented Oct 31, 2021

Copy link
Copy Markdown
Contributor

Hi @ericspod and @wyli ,

Thanks for the great PR, please wait a while before merging it.
I will try to review it tonight.

Thanks.

@Nic-Ma

Nic-Ma commented Nov 1, 2021

Copy link
Copy Markdown
Contributor

/build

1 similar comment
@wyli

wyli commented Nov 1, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put some minor comments inline.
Others look good to me.

Thanks.

Comment thread requirements-dev.txt
wyli added 2 commits November 1, 2021 11:28
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Nov 1, 2021

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli enabled auto-merge (squash) November 1, 2021 12:33
@wyli wyli merged commit 3339f43 into Project-MONAI:dev Nov 1, 2021
@wyli wyli deleted the adds-vis branch November 16, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

util to visualise 3d volumes

3 participants