Skip to content

3142 Add backend to utility transforms#3186

Merged
Nic-Ma merged 13 commits into
Project-MONAI:devfrom
Nic-Ma:add-backend-to-transforms
Oct 26, 2021
Merged

3142 Add backend to utility transforms#3186
Nic-Ma merged 13 commits into
Project-MONAI:devfrom
Nic-Ma:add-backend-to-transforms

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Oct 26, 2021

Copy link
Copy Markdown
Contributor

Fixes #3142 .

Description

This PR is follow up of #3142 , added backend to the utility transforms.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma changed the title [WIP] 3142 Add backend to utility transforms 3142 Add backend to utility transforms Oct 26, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review October 26, 2021 04:17
@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli October 26, 2021 04:18
@Nic-Ma

Nic-Ma commented Oct 26, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Oct 26, 2021

Copy link
Copy Markdown
Contributor Author

/build

Comment thread tests/test_convert_to_multi_channel.py Outdated
Nic-Ma and others added 2 commits October 26, 2021 19:53
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Oct 26, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Oct 26, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma requested a review from wyli October 26, 2021 11:54
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@Nic-Ma

Nic-Ma commented Oct 26, 2021

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

Comment thread tests/test_map_label_value.py
@wyli

wyli commented Oct 26, 2021

Copy link
Copy Markdown
Contributor

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) October 26, 2021 15:23
@Nic-Ma Nic-Ma merged commit 65c253e into Project-MONAI:dev Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some transforms randomly output numpy or tensor that can't collate

3 participants