Skip to content

3174 Add support to scale datalist#3175

Merged
wyli merged 9 commits into
Project-MONAI:devfrom
Nic-Ma:3174-scale-datalist
Oct 25, 2021
Merged

3174 Add support to scale datalist#3175
wyli merged 9 commits into
Project-MONAI:devfrom
Nic-Ma:3174-scale-datalist

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Oct 22, 2021

Copy link
Copy Markdown
Contributor

Fixes #3174 .

Description

This PR implemented the logic to scale a datalist.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Oct 22, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Oct 22, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma

Nic-Ma commented Oct 24, 2021

Copy link
Copy Markdown
Contributor Author

/build

1 similar comment
@Nic-Ma

Nic-Ma commented Oct 24, 2021

Copy link
Copy Markdown
Contributor Author

/build

wyli
wyli approved these changes Oct 24, 2021
View reviewed changes

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@Nic-Ma
[DLMED] update according to comments
239a4e1 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Oct 24, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) October 24, 2021 12:55
@Nic-Ma

Nic-Ma commented Oct 24, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma

Nic-Ma commented Oct 24, 2021

Copy link
Copy Markdown
Contributor Author

Hi @wyli @madil90 ,

The blossom test failed with "oss vulnerability scan failed", root cause is: Detect was unable to connect to Black Duck. Check your configuration and connection.
Any idea how to fix?

Thanks.

@wyli

wyli commented Oct 24, 2021

Copy link
Copy Markdown
Contributor

/build

2 similar comments
@wyli

wyli commented Oct 24, 2021

Copy link
Copy Markdown
Contributor

/build

@Nic-Ma

Nic-Ma commented Oct 25, 2021

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli disabled auto-merge October 25, 2021 07:38
@wyli wyli merged commit a2027ec into Project-MONAI:dev Oct 25, 2021
dongyang0122
dongyang0122 reviewed Oct 25, 2021
View reviewed changes

@dongyang0122 dongyang0122 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dongyang0122 dongyang0122 dongyang0122 left review comments
@wyli wyli wyli approved these changes
@rijobro rijobro Awaiting requested review from rijobro
@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support to scale datalist for training

3 participants

@Nic-Ma @wyli @dongyang0122