Skip to content

3142 Fix mixed output data type in transforms#3157

Merged
Nic-Ma merged 12 commits into
Project-MONAI:devfrom
Nic-Ma:3142-fix-mixed-data-type
Oct 21, 2021
Merged

3142 Fix mixed output data type in transforms#3157
Nic-Ma merged 12 commits into
Project-MONAI:devfrom
Nic-Ma:3142-fix-mixed-data-type

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Oct 20, 2021

Copy link
Copy Markdown
Contributor

Fixes #3142 .

Description

Hi @rijobro @wyli , this PR is followup of #3142 . I checked all the transforms to make the output be consistent and added backends to several transforms.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Oct 20, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Oct 20, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli October 20, 2021 17:02
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Oct 20, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Oct 20, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma

Nic-Ma commented Oct 21, 2021

Copy link
Copy Markdown
Contributor Author

/build

1 similar comment
@Nic-Ma

Nic-Ma commented Oct 21, 2021

Copy link
Copy Markdown
Contributor Author

/build

@Nic-Ma

Nic-Ma commented Oct 21, 2021

Copy link
Copy Markdown
Contributor Author

/integration-test

@Nic-Ma

Nic-Ma commented Oct 21, 2021

Copy link
Copy Markdown
Contributor Author

/build

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@Nic-Ma Nic-Ma enabled auto-merge (squash) October 21, 2021 08:09
@Nic-Ma Nic-Ma merged commit 7da6130 into Project-MONAI:dev Oct 21, 2021
@Nic-Ma Nic-Ma mentioned this pull request Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some transforms randomly output numpy or tensor that can't collate

2 participants