Skip to content

3114 Add fast training integration test#3120

Merged
wyli merged 11 commits into
Project-MONAI:devfrom
Nic-Ma:3114-add-fast-integration-test
Oct 14, 2021
Merged

3114 Add fast training integration test#3120
wyli merged 11 commits into
Project-MONAI:devfrom
Nic-Ma:3114-add-fast-integration-test

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Oct 13, 2021

Copy link
Copy Markdown
Contributor

Fixes #3114 .

Description

This PR added integration test for our fast training solution with synthetic data.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Oct 13, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Oct 13, 2021

Copy link
Copy Markdown
Contributor Author

/integration-test

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli October 13, 2021 11:13
Comment thread tests/test_integration_fast_train.py
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Oct 14, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma

Nic-Ma commented Oct 14, 2021

Copy link
Copy Markdown
Contributor Author

/integration-test

@Nic-Ma

Nic-Ma commented Oct 14, 2021

Copy link
Copy Markdown
Contributor Author

/build

@wyli

wyli commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

looks like some errors from the latest integration? https://github.com/Project-MONAI/MONAI/runs/3890077106?check_suite_focus=true

Comment thread tests/test_integration_fast_train.py
@Nic-Ma Nic-Ma requested a review from wyli October 14, 2021 16:06
@wyli

wyli commented Oct 14, 2021

Copy link
Copy Markdown
Contributor

/integration-test
/build

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it passes the integration tests.

@wyli wyli merged commit 6dc65db into Project-MONAI:dev Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

integration tests for the fast training tutorials

2 participants