Skip to content

remove false positive tests #3046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wyli merged 1 commit into from
Sep 29, 2021
Merged

remove false positive tests #3046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/test_savitzky_golay_smooth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,14 @@
np.expand_dims(np.array([1.0]), 0), # Input data: Single value
np.expand_dims(np.array([1 / 3]), 0), # Expected output: With a window length of 3 and polyorder 1
# output should be equal to mean of 0, 1 and 0 = 1/3 (because input will be zero-padded and a linear fit performed)
1e-15, # absolute tolerance
1e-5, # absolute tolerance
]

TEST_CASE_2D_AXIS_2 = [
{"window_length": 3, "order": 1, "axis": 2}, # along axis 2 (second spatial dim)
np.expand_dims(np.ones((2, 3)), 0),
np.expand_dims(np.array([[2 / 3, 1.0, 2 / 3], [2 / 3, 1.0, 2 / 3]]), 0),
1e-15, # absolute tolerance
1e-5, # absolute tolerance
]

# Replicated-padding trivial tests
Expand All @@ -42,7 +42,7 @@
np.expand_dims(np.array([1.0]), 0), # Input data: Single value
np.expand_dims(np.array([1.0]), 0), # Expected output: With a window length of 3 and polyorder 1
# output will be equal to mean of [1, 1, 1] = 1 (input will be nearest-neighbour-padded and a linear fit performed)
1e-15, # absolute tolerance
1e-5, # absolute tolerance
]

# Sine smoothing
Expand All @@ -63,15 +63,15 @@ class TestSavitzkyGolaySmooth(unittest.TestCase):
def test_value(self, arguments, image, expected_data, atol):
for p in TEST_NDARRAYS:
result = SavitzkyGolaySmooth(**arguments)(p(image.astype(np.float32)))
torch.testing.assert_allclose(result, p(expected_data.astype(np.float32)), rtol=1e-7, atol=atol)
torch.testing.assert_allclose(result, p(expected_data.astype(np.float32)), rtol=1e-4, atol=atol)


class TestSavitzkyGolaySmoothREP(unittest.TestCase):
@parameterized.expand([TEST_CASE_SINGLE_VALUE_REP])
def test_value(self, arguments, image, expected_data, atol):
for p in TEST_NDARRAYS:
result = SavitzkyGolaySmooth(**arguments)(p(image.astype(np.float32)))
torch.testing.assert_allclose(result, p(expected_data.astype(np.float32)), rtol=1e-7, atol=atol)
torch.testing.assert_allclose(result, p(expected_data.astype(np.float32)), rtol=1e-4, atol=atol)


if __name__ == "__main__":
Expand Down