Skip to content

2885 2899 Add support to support subclass of Tensor or numpy array#2900

Merged
wyli merged 8 commits into
Project-MONAI:devfrom
Nic-Ma:2899-fix-itk-type
Sep 6, 2021
Merged

2885 2899 Add support to support subclass of Tensor or numpy array#2900
wyli merged 8 commits into
Project-MONAI:devfrom
Nic-Ma:2899-fix-itk-type

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Sep 6, 2021

Copy link
Copy Markdown
Contributor

Fixes #2885 #2899 .

Description

This PR fixed case that data is subclass of Tensor or numpy array.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Sep 6, 2021

Copy link
Copy Markdown
Contributor Author

/black

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma changed the title 2899 Fix ITK return array type 2899 Add support to support subclass of Tensor or numpy array Sep 6, 2021
@Nic-Ma

Nic-Ma commented Sep 6, 2021

Copy link
Copy Markdown
Contributor Author

/black

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Sep 6, 2021

Copy link
Copy Markdown
Contributor Author

/black

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma changed the title 2899 Add support to support subclass of Tensor or numpy array 2885 2899 Add support to support subclass of Tensor or numpy array Sep 6, 2021
Signed-off-by: Nic Ma <nma@nvidia.com>
@wyli

wyli commented Sep 6, 2021

Copy link
Copy Markdown
Contributor

/build

@wyli wyli merged commit 9c7b71f into Project-MONAI:dev Sep 6, 2021
wyli pushed a commit to Borda/MONAI that referenced this pull request Sep 6, 2021
…roject-MONAI#2900)

* [DLMED] fix type issue

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix test

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] simplify the change

Signed-off-by: Nic Ma <nma@nvidia.com>

* [DLMED] fix flake8

Signed-off-by: Nic Ma <nma@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

About ValueError: Unsupported output type: <class 'itk.itkPyBufferPython.NDArrayITKBase'> that occurs when transforms compose

2 participants