Skip to content

ShiftIntensityd, RandShiftIntensityd#2839

Merged
rijobro merged 7 commits into
Project-MONAI:devfrom
rijobro:shift_intensityd
Aug 25, 2021
Merged

ShiftIntensityd, RandShiftIntensityd#2839
rijobro merged 7 commits into
Project-MONAI:devfrom
rijobro:shift_intensityd

Conversation

@rijobro

@rijobro rijobro commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

Description

Torch transform for ShiftIntensityd and RandShiftIntensityd. Requires https://github.com/Project-MONAI/MONAI/pull/2838/files.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro rijobro requested review from Nic-Ma and wyli August 25, 2021 10:15
@rijobro

rijobro commented Aug 25, 2021

Copy link
Copy Markdown
Contributor Author

@Nic-Ma This should be the last of your required BRATS transforms - #2819 (comment).

rijobro and others added 3 commits August 25, 2021 11:30

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, put some minor comments.

Thanks.

Comment thread tests/test_shift_intensityd.py
@rijobro

rijobro commented Aug 25, 2021

Copy link
Copy Markdown
Contributor Author

/build

@rijobro

rijobro commented Aug 25, 2021

Copy link
Copy Markdown
Contributor Author

@wyli do I have the rights to trigger blossom-ci by using /build?

@rijobro rijobro enabled auto-merge (squash) August 25, 2021 15:02
@wyli

wyli commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

/build

1 similar comment
@wyli

wyli commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

/build

@rijobro rijobro merged commit 26f8446 into Project-MONAI:dev Aug 25, 2021
@rijobro rijobro deleted the shift_intensityd branch August 26, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants