Skip to content

2707 Add support to randomly fill cutout holes#2837

Merged
Nic-Ma merged 17 commits into
Project-MONAI:devfrom
Nic-Ma:2707-random-fill
Aug 25, 2021
Merged

2707 Add support to randomly fill cutout holes#2837
Nic-Ma merged 17 commits into
Project-MONAI:devfrom
Nic-Ma:2707-random-fill

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

Fixes #2707 .

Description

This PR added support to fill the holes of cutout with random values instead of constant.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Nic-Ma and others added 8 commits February 1, 2021 19:15
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Aug 25, 2021

Copy link
Copy Markdown
Contributor Author

/black

Signed-off-by: Nic Ma <nma@nvidia.com>
Nic-Ma added 5 commits August 25, 2021 15:06
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli August 25, 2021 07:54
@Nic-Ma Nic-Ma changed the title [WIP] 2707 Add support to randomly fill cutout holes 2707 Add support to randomly fill cutout holes Aug 25, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review August 25, 2021 07:55

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, maybe we'll also need an option to set the random range of the fill values to min(img), max(img)

@wyli

wyli commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

/build

@Nic-Ma

Nic-Ma commented Aug 25, 2021

Copy link
Copy Markdown
Contributor Author

Looks good to me, maybe we'll also need an option to set the random range of the fill values to min(img), max(img)

That's a good point, I will update to use fill_value=None to automatically compute the min and max from image.

Thanks.

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Aug 25, 2021

Copy link
Copy Markdown
Contributor Author

/black

Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@Nic-Ma

Nic-Ma commented Aug 25, 2021

Copy link
Copy Markdown
Contributor Author

Hi @wyli ,

Do you know why the DepSource tests always cancel even I re-run it?

Thanks in advance.

@wyli

wyli commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) August 25, 2021 14:00
@wyli

wyli commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

/build

@Nic-Ma Nic-Ma merged commit a88976c into Project-MONAI:dev Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Augmentation Transform | InCut & OutCut Dropping (ETA 08/27/21)

3 participants