Skip to content

2796 Enhance doc-string of cache datasets#2799

Merged
Nic-Ma merged 9 commits into
Project-MONAI:devfrom
Nic-Ma:2796-enhance-cache-doc
Aug 18, 2021
Merged

2796 Enhance doc-string of cache datasets#2799
Nic-Ma merged 9 commits into
Project-MONAI:devfrom
Nic-Ma:2796-enhance-cache-doc

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Aug 18, 2021

Copy link
Copy Markdown
Contributor

Fixes #2796 .

Description

This PR enhanced the doc-string of cache datasets according to users' feedback.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Aug 18, 2021

Copy link
Copy Markdown
Contributor Author

/black

Comment thread monai/data/dataset.py Outdated
Comment thread monai/data/dataset.py Outdated
Co-authored-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma force-pushed the 2796-enhance-cache-doc branch from 2cbee47 to 12c07bf Compare August 18, 2021 10:58
Co-authored-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma force-pushed the 2796-enhance-cache-doc branch from ea757fa to 8a782c3 Compare August 18, 2021 11:00
@Nic-Ma Nic-Ma enabled auto-merge (squash) August 18, 2021 11:00
@Nic-Ma

Nic-Ma commented Aug 18, 2021

Copy link
Copy Markdown
Contributor Author

/black

monai-bot and others added 2 commits August 18, 2021 11:11
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma merged commit e223932 into Project-MONAI:dev Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants