Skip to content

[WIP] 2620 Add ITKWriter for other formats#2647

Closed
Nic-Ma wants to merge 12 commits into
Project-MONAI:devfrom
Nic-Ma:2620-add-itkwriter
Closed

[WIP] 2620 Add ITKWriter for other formats#2647
Nic-Ma wants to merge 12 commits into
Project-MONAI:devfrom
Nic-Ma:2620-add-itkwriter

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Jul 23, 2021

Copy link
Copy Markdown
Contributor

Fixes #2620 .

Description

This PR added ITKWriter to support more image formats.

Status

Work in progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Nic-Ma and others added 8 commits February 1, 2021 19:15
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Jul 23, 2021

Copy link
Copy Markdown
Contributor Author

Hi @rijobro @wyli @ericspod ,

I am blocked by an issue that I didn't find the API to set affine matrix in ITK image, already filed a ticket to ITK repo:
InsightSoftwareConsortium/ITK#2663
Do you guys have any experience or ideas?
Actually, if someone can share a detailed python tutorial or example to save numpy array into many different formats(PNG, DICOM, DICOM series, NIfTI, etc.) with ITK, that would be extremely helpful for us. CC @thewtex

Thanks in advance.

Nic-Ma added 3 commits July 23, 2021 17:59
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
@madil90

madil90 commented Jul 26, 2021

Copy link
Copy Markdown
Contributor

/build

1 similar comment
@madil90

madil90 commented Jul 26, 2021

Copy link
Copy Markdown
Contributor

/build

Signed-off-by: Nic Ma <nma@nvidia.com>
@wyli

wyli commented Jul 26, 2021

Copy link
Copy Markdown
Contributor

I can work on this feature because I revised the reader recently and now familiar with these

@Nic-Ma

Nic-Ma commented Jul 26, 2021

Copy link
Copy Markdown
Contributor Author

I can work on this feature because I revised the reader recently and now familiar with these

That would be great.
I almost finished this PR for the basic saving with ITK, just blocked by the multi-channels case now, maybe I can complete this PR as initial part of writers? Then you can enhance with more your ideas?

Thanks.

@wyli

wyli commented Jul 26, 2021

Copy link
Copy Markdown
Contributor

We haven't started the review yet, I think this basic implementation needs some more work. I'll start a new PR on this, using some ideas from this PR, what do you think?

@Nic-Ma

Nic-Ma commented Jul 26, 2021

Copy link
Copy Markdown
Contributor Author

We haven't started the review yet, I think this basic implementation needs some more work. I'll start a new PR on this, using some ideas from this PR, what do you think?

OK, plan sounds good.

Thanks.

@madil90

madil90 commented Jul 27, 2021

Copy link
Copy Markdown
Contributor

/build

3 similar comments
@madil90

madil90 commented Aug 2, 2021

Copy link
Copy Markdown
Contributor

/build

@madil90

madil90 commented Aug 6, 2021

Copy link
Copy Markdown
Contributor

/build

@madil90

madil90 commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

/build

@thewtex

thewtex commented Aug 20, 2021

Copy link
Copy Markdown
Contributor

Hi @rijobro @wyli @ericspod ,

I am blocked by an issue that I didn't find the API to set affine matrix in ITK image, already filed a ticket to ITK repo:
InsightSoftwareConsortium/ITK#2663
Do you guys have any experience or ideas?
Actually, if someone can share a detailed python tutorial or example to save numpy array into many different formats(PNG, DICOM, DICOM series, NIfTI, etc.) with ITK, that would be extremely helpful for us. CC @thewtex

Thanks in advance.

Discussed more in InsightSoftwareConsortium/ITK#2663, but https://gist.github.com/thewtex/9503448d2ad1dfacc2cbd620d95d3dac is hopefully helpful.

@madil90

madil90 commented Aug 27, 2021

Copy link
Copy Markdown
Contributor

/build

3 similar comments
@madil90

madil90 commented Sep 8, 2021

Copy link
Copy Markdown
Contributor

/build

@madil90

madil90 commented Sep 13, 2021

Copy link
Copy Markdown
Contributor

/build

@madil90

madil90 commented Sep 30, 2021

Copy link
Copy Markdown
Contributor

/build

@lukasfolle

Copy link
Copy Markdown

Any updates on this? I would really appreciate a Dicom out support for MONAI.

@dyollb

dyollb commented Nov 14, 2021

Copy link
Copy Markdown
Contributor

Any update on this? I was thinking of writing a custom ImageWriter for our in-house file format based on hdf5.

@Nic-Ma

Nic-Ma commented Nov 15, 2021

Copy link
Copy Markdown
Contributor Author

Hi @dyollb ,

As @wyli said in #2647 (comment), I think we need more discussion about this topic.

Thanks.

@wyli

wyli commented Jan 18, 2022

Copy link
Copy Markdown
Contributor

thanks, I'm closing this in favour of #3674.

@wyli wyli closed this Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Image writer with itk backend to support more output image formats

6 participants