Skip to content

2635 Enhance doc-string of UNet for spatial size#2641

Merged
Nic-Ma merged 11 commits into
Project-MONAI:devfrom
Nic-Ma:2635-add-unet-input-size
Jul 26, 2021
Merged

2635 Enhance doc-string of UNet for spatial size#2641
Nic-Ma merged 11 commits into
Project-MONAI:devfrom
Nic-Ma:2635-add-unet-input-size

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Jul 22, 2021

Copy link
Copy Markdown
Contributor

Fixes #2635 .

Description

As several users asked questions about the input size of UNet, this PR enhanced the doc-string to make it clear.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Jul 22, 2021

Copy link
Copy Markdown
Contributor Author

/black

Comment thread tests/test_unet.py
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Jul 22, 2021

Copy link
Copy Markdown
Contributor Author

/black

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Jul 22, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma Nic-Ma requested a review from yiheng-wang-nv July 22, 2021 08:29
Comment thread monai/networks/nets/unet.py
@Nic-Ma Nic-Ma changed the title 2635 Enhance doc-string of UNet for spatial size [WIP] 2635 Enhance doc-string of UNet for spatial size Jul 23, 2021
@yiheng-wang-nv

Copy link
Copy Markdown
Contributor

Supplement: test_unet.py does not cover the parameters: kernel_size and up_kernel_size, and strides is always (2, 2). I think more test cases are necessary.

@Nic-Ma

Nic-Ma commented Jul 23, 2021

Copy link
Copy Markdown
Contributor Author

Supplement: test_unet.py does not cover the parameters: kernel_size and up_kernel_size, and strides is always (2, 2). I think more test cases are necessary.

Sure, please feel free to submit commits directly.

Thanks.

Comment thread monai/networks/nets/unet.py Outdated
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Jul 26, 2021

Copy link
Copy Markdown
Contributor Author

/black

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma changed the title [WIP] 2635 Enhance doc-string of UNet for spatial size 2635 Enhance doc-string of UNet for spatial size Jul 26, 2021
@Nic-Ma

Nic-Ma commented Jul 26, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma Nic-Ma enabled auto-merge (squash) July 26, 2021 15:49
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
@Nic-Ma Nic-Ma merged commit 141e9db into Project-MONAI:dev Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants