Skip to content

2590 Enhance all the SpatialPad related#2597

Merged
Nic-Ma merged 5 commits into
Project-MONAI:devfrom
Nic-Ma:2590-enhance-other-pad-args
Jul 14, 2021
Merged

2590 Enhance all the SpatialPad related#2597
Nic-Ma merged 5 commits into
Project-MONAI:devfrom
Nic-Ma:2590-enhance-other-pad-args

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Jul 14, 2021

Copy link
Copy Markdown
Contributor

Fixes #2590 .

Description

Follow-up of #2594 , this PR enhanced all the other SpatialPad related logic and added unit tests.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma

Nic-Ma commented Jul 14, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli July 14, 2021 09:14

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick update

@Nic-Ma

Nic-Ma commented Jul 14, 2021

Copy link
Copy Markdown
Contributor Author

Hi @wyli ,

Please note that I didn't add args for the SpatialPad in the inverse method of some crop transforms. I think we discussed to keep the inverse padding simple so far.

Thanks.

@Nic-Ma Nic-Ma enabled auto-merge (squash) July 14, 2021 09:23
@Nic-Ma Nic-Ma merged commit 813368b into Project-MONAI:dev Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants