Skip to content

2432 Add RandCropByLabelClasses transform#2557

Merged
Nic-Ma merged 18 commits into
Project-MONAI:devfrom
Nic-Ma:2432-add-class-ratio-crop
Jul 13, 2021
Merged

2432 Add RandCropByLabelClasses transform#2557
Nic-Ma merged 18 commits into
Project-MONAI:devfrom
Nic-Ma:2432-add-class-ratio-crop

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Jul 8, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #2432 #2560 .

Description

This PR added the RandCropByLabelClasses transform.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@madil90

madil90 commented Jul 8, 2021

Copy link
Copy Markdown
Contributor

/build

@Nic-Ma
[DLMED] add all the transforms
8803885 
Signed-off-by: Nic Ma <nma@nvidia.com>
@madil90

madil90 commented Jul 8, 2021

Copy link
Copy Markdown
Contributor

/build

1 similar comment
@madil90

madil90 commented Jul 8, 2021

Copy link
Copy Markdown
Contributor

/build

This was referenced Jul 11, 2021
Closed
Open
Nic-Ma added 4 commits July 12, 2021 10:30
@Nic-Ma
[DLMED] fix typo
770c6b6 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] add tests for ClassesToIndices transforms
ec9eb59 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] add unit tests and documents
8494cf2 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] fix flake8 and add inverse tests
34babb3 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma changed the title [WIP] 2432 Add RandCropByClassesRatio transform 2432 Add RandCropByLabelClasses transform Jul 12, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review July 12, 2021 06:18
@Nic-Ma

Nic-Ma commented Jul 12, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli July 12, 2021 06:19
wyli
wyli reviewed Jul 12, 2021
View reviewed changes
Comment thread monai/transforms/utils.py Outdated
wyli
wyli reviewed Jul 12, 2021
View reviewed changes

@wyli wyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks I have some minor comments

Comment thread monai/transforms/utils.py Outdated
Comment thread monai/transforms/utils.py Outdated
Comment thread monai/transforms/croppad/dictionary.py Outdated
@Nic-Ma
[DLMED] update according to comments
d621443 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Jul 13, 2021

Copy link
Copy Markdown
Contributor Author

Hi @wyli ,

Thanks for your review.
I updated the PR according to your comments.
Could you please help review it again?

Thanks in advance.

@Nic-Ma

Nic-Ma commented Jul 13, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma Nic-Ma requested a review from wyli July 13, 2021 02:52
Nic-Ma added 2 commits July 13, 2021 16:42
@Nic-Ma
[DLMED] optimize random choice
c52180f 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma
[DLMED] add check for num_samples
8dc89bd 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Jul 13, 2021

Copy link
Copy Markdown
Contributor Author

/black

wyli
wyli reviewed Jul 13, 2021
View reviewed changes
Comment thread monai/transforms/utils.py Outdated
@Nic-Ma
[DLMED] add default value to ratios
b23190a 
Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma

Nic-Ma commented Jul 13, 2021

Copy link
Copy Markdown
Contributor Author

/black

@Nic-Ma Nic-Ma enabled auto-merge (squash) July 13, 2021 10:06
@Nic-Ma Nic-Ma merged commit 2cb1efc into Project-MONAI:dev Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes
@rijobro rijobro Awaiting requested review from rijobro
@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support to set pos/neg crop ratio for every class

3 participants

@Nic-Ma @madil90 @wyli