2506 Fix strict_shape in CheckointLoader#2508
Merged
Merged
Conversation
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
wyli
reviewed
Jul 2, 2021
Contributor
|
/integation-test |
Signed-off-by: Nic Ma <nma@nvidia.com>
405ad7d to
86f5c97
Compare
Contributor
Author
|
/black |
wyli
reviewed
Jul 2, 2021
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
wyli
reviewed
Jul 2, 2021
sandylaker
reviewed
Jul 2, 2021
wyli
approved these changes
Jul 2, 2021
wyli
left a comment
Contributor
There was a problem hiding this comment.
Thanks, I think the API could be improved, but I guess that is beyond this bug fix PR
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Signed-off-by: Nic Ma <nma@nvidia.com>
Contributor
Author
|
/black |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
wyli
pushed a commit
to wyli/MONAI
that referenced
this pull request
Jul 5, 2021
* [DLMED] fix strict_shape Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] add warning message Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] update according to comments Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] add links Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] Enhance doc-strings Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] enhance CI tests Signed-off-by: Nic Ma <nma@nvidia.com> * [DLMED] fix flake8 Signed-off-by: Nic Ma <nma@nvidia.com> * [MONAI] python code formatting Signed-off-by: monai-bot <monai.miccai2019@gmail.com> Co-authored-by: monai-bot <monai.miccai2019@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2506 .
Description
This PR fixed the strick_shape arg issue for non-model items.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.