Skip to content

2478 Update highlight features page for v0.6#2490

Merged
wyli merged 14 commits into
Project-MONAI:devfrom
Nic-Ma:2478-highlight-0.6
Jul 7, 2021
Merged

2478 Update highlight features page for v0.6#2490
wyli merged 14 commits into
Project-MONAI:devfrom
Nic-Ma:2478-highlight-0.6

Conversation

@Nic-Ma

@Nic-Ma Nic-Ma commented Jun 30, 2021

Copy link
Copy Markdown
Contributor

Fixes #2478 .

Description

This PR updated the highlight features page for v0.6 release.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma changed the title [WIP] 2478 Updatew highlight features page for v0.6 [WIP] 2478 Update highlight features page for v0.6 Jul 2, 2021
@Nic-Ma

Nic-Ma commented Jul 2, 2021

Copy link
Copy Markdown
Contributor Author

Hi @wyli ,

  1. Could you please help add the MMAR tutorial(if you are developing) link in the highlight features?
  2. Do we have any new important features in the C++ and CUDA components?
  3. And do you have any other highlight features that not involved in this PR?

Thanks in advance.

@Nic-Ma Nic-Ma changed the title [WIP] 2478 Update highlight features page for v0.6 2478 Update highlight features page for v0.6 Jul 5, 2021
@Nic-Ma Nic-Ma marked this pull request as ready for review July 5, 2021 13:44
@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli July 5, 2021 13:44
@Nic-Ma

Nic-Ma commented Jul 5, 2021

Copy link
Copy Markdown
Contributor Author

@wyli please feel free to edit or add / delete the content when you reviewing the PR.

Thanks.

@wyli

wyli commented Jul 5, 2021

Copy link
Copy Markdown
Contributor

Hi @wyli ,

  1. Could you please help add the MMAR tutorial(if you are developing) link in the highlight features?
  2. Do we have any new important features in the C++ and CUDA components?
  3. And do you have any other highlight features that not involved in this PR?

Thanks in advance.

sure, I'm updating the mmar tutorial according to Project-MONAI/tutorials#246
for (2), @charliebudd could you please share the figures of GMM? we can include the full demo later in the tutorial repo

@Nic-Ma

Nic-Ma commented Jul 7, 2021

Copy link
Copy Markdown
Contributor Author

Hi @wyli ,

BTW, please copy the new content to whatsnew.md page when you finalized the highlights content.

Thanks in advance.

Nic-Ma and others added 6 commits July 7, 2021 11:06
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 2478-highlight-0.6 branch from 18c818f to 1b2c9e3 Compare July 7, 2021 10:06
wyli added 2 commits July 7, 2021 14:21
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@Nic-Ma

Nic-Ma commented Jul 7, 2021

Copy link
Copy Markdown
Contributor Author

Hi @wyli ,

I want to add a section to highlight the deollate feature, is it OK for me to push a commit now?

Thanks.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli

wyli commented Jul 7, 2021

Copy link
Copy Markdown
Contributor

Hi @wyli ,

I want to add a section to highlight the deollate feature, is it OK for me to push a commit now?

Thanks.

sure (I feel this doc is too dense, nobody would read through it...)

@Nic-Ma

Nic-Ma commented Jul 7, 2021

Copy link
Copy Markdown
Contributor Author

Hi @wyli ,

Cool, thanks.
Actually, many Clara users read this document carefully as the start-point.
I was planning to split it into several separate pages after this v0.6 release.

Thanks.

Signed-off-by: Nic Ma <nma@nvidia.com>
@Nic-Ma Nic-Ma force-pushed the 2478-highlight-0.6 branch from 66f84fa to a24a53a Compare July 7, 2021 14:42
@Nic-Ma

Nic-Ma commented Jul 7, 2021

Copy link
Copy Markdown
Contributor Author

Hi @wyli ,

I don't have more items to add, please feel free to review the PR and complete it.

Thanks very much for your enhancement and great figures.

Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli merged commit 3254ac3 into Project-MONAI:dev Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update feature highlight doc for v0.6.0 (7/July)

2 participants