2362 skip MMAR downloading if the remote has http 500#2363
Merged
Conversation
Nic-Ma
approved these changes
Jun 14, 2021
Nic-Ma
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your quick fix, I put some minor comments inline.
Others look good to me.
Thanks.
| download_mmar(idx, mmar_dir=tmp_dir, progress=False) # repeated to check caching | ||
| self.assertTrue(os.path.exists(os.path.join(tmp_dir, idx))) | ||
| except (ContentTooShortError, HTTPError, RuntimeError) as e: | ||
| print(str(e)) |
Contributor
There was a problem hiding this comment.
Could you please add a basic test for the error message? Just like:
https://github.com/Project-MONAI/MONAI/blob/dev/tests/test_download_and_extract.py#L36
Thanks.
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
9dcff43 to
09d2bd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li wenqil@nvidia.com
Fixes #2362
Description
skip downloading if there's a remote server error
Status
Ready
Types of changes
./runtests.sh --quick --unittests.