2330 Enhance all_gather APIs for regular PyTorch programs#2331
Conversation
merge master
merge master
merge master
Signed-off-by: Nic Ma <nma@nvidia.com>
7997bf0 to
2ae5eee
Compare
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
1 similar comment
|
/black |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
wyli
left a comment
There was a problem hiding this comment.
thanks, please see some comments inline. there are some utility functions moved from monai.handlers.utils to monai.utils, we need a deprecation method for this type of change as well @ericspod, any suggestions for this PR or shall we have another PR for the deprecating module?
Signed-off-by: Nic Ma <nma@nvidia.com>
|
/black |
|
Hi @wyli , Thanks for your review and comments. Or any other suggestions? Or some overall advanced method to handle it? Thanks. |
|
For now you can add the warning but I'm going to have a PR shortly on a more involved mechanism. |
Signed-off-by: Nic Ma <nma@nvidia.com>
7ac69c8 to
cbebdff
Compare
|
Hi @ericspod , Sounds good! Thanks. |
|
/black |
Signed-off-by: monai-bot <monai.miccai2019@gmail.com>
Signed-off-by: Nic Ma <nma@nvidia.com>
Fixes #2330 .
basic warnings for #2335
Description
This PR adjusted the
evenly_divisible_all_gatherandstring_list_all_gatherAPIs to support regular PyTorch programs.Thanks for @vfdev-5 's help, referring to the basic idea of ignite
all_gather(string).And resolved the max_length=1024 issue of ignite v0.4.4.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests.make htmlcommand in thedocs/folder.