Skip to content

2056 additional deepgrow workflow events#2305

Merged
wyli merged 2 commits into
Project-MONAI:devfrom
wyli:2056-additional-events
Jun 4, 2021
Merged

2056 additional deepgrow workflow events#2305
wyli merged 2 commits into
Project-MONAI:devfrom
wyli:2056-additional-events

Conversation

@wyli

@wyli wyli commented Jun 3, 2021

Copy link
Copy Markdown
Contributor

Signed-off-by: Wenqi Li wenqil@nvidia.com

Fixes #2056

Description

this PR adds two new events to IterationEvents, which are useful for advanced workflows and debugging.
it's tested with the deepgrow workflow

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli requested review from Nic-Ma, diazandr3s and rijobro June 3, 2021 22:03
@wyli wyli changed the title additional deepgrow workflow events 2056 additional deepgrow workflow events Jun 3, 2021

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your quick PR.
I put some comments for a minor issue, others look good to me.

Thanks.

Comment thread monai/apps/deepgrow/interaction.py Outdated
@wyli wyli force-pushed the 2056-additional-events branch from ac0488c to e6eda36 Compare June 4, 2021 07:59
@wyli

wyli commented Jun 4, 2021

Copy link
Copy Markdown
Contributor Author

theattach method is in fact incorrect, interaction.attach(engine) gives

ValueError: Error adding <monai.apps.deepgrow.interaction.Interaction object at 0x7fa719b25d10> 
'handler': takes parameters ['engine', 'batchdata'] but will be called with [](missing a required argument: 'engine').

wyli added 2 commits June 4, 2021 09:01
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the 2056-additional-events branch from e6eda36 to 649fa30 Compare June 4, 2021 08:01
@wyli wyli requested a review from Nic-Ma June 4, 2021 08:02

@Nic-Ma Nic-Ma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your quick update.
Looks good to me now.

Thanks.

@wyli wyli enabled auto-merge (squash) June 4, 2021 08:16
@wyli wyli merged commit c1e06f5 into Project-MONAI:dev Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

additional events in the deepgrow interaction engine

2 participants